Add support for numbers in makeStandardSymbol#3
Open
TheDcoder wants to merge 3 commits intoKittyCatTech:masterfrom
Open
Add support for numbers in makeStandardSymbol#3TheDcoder wants to merge 3 commits intoKittyCatTech:masterfrom
TheDcoder wants to merge 3 commits intoKittyCatTech:masterfrom
Conversation
Dealing with crypto currencies with numericals in their symbol is now possible
Literally return the `$exchangeSymbol`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of hair pulling was involved as I had almost no experience with PHP until I finally figured out why crypto currencies with numbers were "messed up"