feat: Add Variable-Q Transform#113
Merged
KinWaiCheuk merged 1 commit intoKinWaiCheuk:masterfrom Dec 24, 2021
Merged
Conversation
Collaborator
Author
|
@KinWaiCheuk inviting you as reviewer, much thanks! |
KinWaiCheuk
reviewed
Dec 13, 2021
| else: | ||
| x_down = x | ||
|
|
||
| Q = float(self.filter_scale)/(2**(1/self.bins_per_octave)-1) |
Owner
There was a problem hiding this comment.
Isn't this same as line 46? Both self.bins_per_octave and self.filter_scale seem to be unchanged inside the for loop. So maybe there is no need to recompute the Q here? Or am I misunderstanding something?
Collaborator
Author
There was a problem hiding this comment.
Sorry for replying late. You can understand this Q as an "initial value of Q".
Following librosa's implementation, the "variable" part actually lies in lengths of create_cqt_kernels-
The gamma will change the filter lengths as compared to CQT. From what I understand, since filter length and Q are interrelated, by changing the lengths we can also view it as "variable-Q".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add VQT feature, similar to librosa's implementation. TLDR:
gammato dampen the Q factor at lower frequencies, while maintaining roughly a constant Q at higher frequencies.Test plan:
plt.imshowVQT magnitude spectrograms between librosa and nnAudio, overall does not have much difference.There is still some minor value diff between both, mainly due to
lengths- librosa usesfloat, but nnAudio usesint(I keep this implementation so that it is consistent with nnAudio CQT implementation)Added two tests for VQT: (i) at gamma=0, VQT and CQT should be the same; (ii) keep the value diff between librosa and nnAudio within a baseline range (see
tests/test_vqt.py)Ran both

tests/test_vqt.pyandtests/test_cqt.py, both passes