Open
Conversation
|
Someone is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom
filterFnon a column inMaterialReactTable, the column shows the “filtered” icon even when the filter has been cleared.This suggests that the table treats an empty filter value as an active filter.
Expected Behaviour
When the filter is cleared (e.g., multiselect returns an empty array), the column should not display the filtered icon, and the tooltip should not appear.
Actual Behaviour
filterValuebecomes [] when the filter is cleared.The table interprets [] as a truthy/active filter.
The filtered icon and tooltip remain visible even though no filter is applied.
Steps to Reproduce