Solution Implemented in Python#10
Open
bowmanpete123 wants to merge 1 commit intoJuniorDev-TGA:masterfrom
bowmanpete123:PeterBowman
Open
Solution Implemented in Python#10bowmanpete123 wants to merge 1 commit intoJuniorDev-TGA:masterfrom bowmanpete123:PeterBowman
bowmanpete123 wants to merge 1 commit intoJuniorDev-TGA:masterfrom
bowmanpete123:PeterBowman
Conversation
|
Hi Peter. I'd say go with the chain or the approach outlined below. Tests will most probably break/need to be extended and it's expected. A simpler solution without a chain would be to pass two parameters to the validation function:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have I got it right here? I was unsure about implementing a full-on chain with an abstract interface because it would require changing the tests to pass, so I've built something that can pass the unit-tests outright