Skip to content

Comments

Solution Implemented in Python#10

Open
bowmanpete123 wants to merge 1 commit intoJuniorDev-TGA:masterfrom
bowmanpete123:PeterBowman
Open

Solution Implemented in Python#10
bowmanpete123 wants to merge 1 commit intoJuniorDev-TGA:masterfrom
bowmanpete123:PeterBowman

Conversation

@bowmanpete123
Copy link

Have I got it right here? I was unsure about implementing a full-on chain with an abstract interface because it would require changing the tests to pass, so I've built something that can pass the unit-tests outright

@den-t
Copy link

den-t commented Dec 6, 2018

Hi Peter. I'd say go with the chain or the approach outlined below. Tests will most probably break/need to be extended and it's expected.
Currently, the two functions are not DRY (don't repeat yourself) and tests don't cover 'nomax' path.
There're no additional files in commits which is nice. Could you please close the first request?

A simpler solution without a chain would be to pass two parameters to the validation function:

  1. the password to check
  2. a dictionary with tests that should pass
    This way validation could be customised to skip max length or any other checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants