Send link by share screen, copy link from QR code view #63
Conversation
Except in CBScanner.swift from third-party barcode scanner, issue is open: heart/CarBode-Barcode-Scanner-For-SwiftUI#66
Set space between icons in project list
|
Hi, thanks for all the contribution, unfortunately currently I am very engaged in other projects and got little time to review and test all the small changes in detail. |
|
Feel free to separate the localization, dispatchqueues and test-fixes in separate PRs, I can merge those right away |
|
Thank you for your response, I will keep this in mind. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
InteractionEngineer
left a comment
InteractionEngineer
left a comment
There was a problem hiding this comment.
First of all: Thank you for your contribution – I like the features you added to make it easier to share projects with others! Please look into the comments I left on each file modified. After the necessary changes where made, I'm happy to merge your PR and bring your feature to all current users.
There was a problem hiding this comment.
outdated, GRDB is up to date now and two major versions ahead.
There was a problem hiding this comment.
As this is only for preview, and preview works without initializing this struct (again), better remove it completely.
There was a problem hiding this comment.
'animation' was deprecated in iOS 15.0 – so it would be even better to use 'withAnimation'. Your fix works too, though – but let's make the switch sooner than later.
There was a problem hiding this comment.
'animation' was deprecated in iOS 15.0 – so it would be even better to use 'withAnimation'. Your fix works too, though – but let's make the switch sooner than later.
There was a problem hiding this comment.
super helpful feature, thank you! It's best practice to keep logic and interface separated. Would you mind "outsourcing" this feature? This way it can easily be reused in different places and even tested automatically (more easily).
There was a problem hiding this comment.
outdated but correct! …at this time already in the codebase
InteractionEngineer
added
enhancement
3 participants
Added: share Link, copy Link in QR code view, translation
Update: dependencies, unit test
Remove: warnings, bugs :)