Update insticator for 2.6rtb #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'api': (value) => isArrayOfNums(value)}; | ||
| 'api': (value) => isArrayOfNums(value), | ||
| // Ad Pod specific parameters (ORTB 2.6) | ||
| 'podid': (value) => typeof value === 'string' && value.length > 0, |
There was a problem hiding this comment.
we won't reject requests right if this validations fail? Just wondering if something can be done to still process the requests
Author
There was a problem hiding this comment.
No, requests are NOT rejected. this validation only controls whether the param is included and invalid params are skipped, and the bid request still proceeds with valid params.
| } | ||
|
|
||
| // ORTB 2.6: Add billing URL for win notification | ||
| if (bid.burl) { |
There was a problem hiding this comment.
lets add nurl too if prebidjs supports it.
rohanInsticator
left a comment
rohanInsticator
left a comment
There was a problem hiding this comment.
Other than the 2 comments, it looks good.
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… server request (prebid#14370) * Support Interstitial (instl param) in building server request * adjust unit tests for Instl param
This adapter enables publishers to monetize AI-referred traffic through Prebid.js. - Bidder code: panxo - GVL ID: 1527 - Media types: Banner - Features: GDPR/TCF 2.0, CCPA, GPP, COPPA, schain, First Party Data, Price Floors - Requires Panxo Signal script to be loaded before Prebid Documentation: modules/panxoBidAdapter.md Tests: test/spec/modules/panxoBidAdapter_spec.js
* enhance adapter with additional bid parameters * Add additional bid parameters to tests of bridgewellBidAdapter * pass mediaType and size to getFloor --------- Co-authored-by: Laneser <laneser.kuo@gmail.com>
…Prebid.js into update-insticator-for-2.6rtb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information