This repository was archived by the owner on Apr 8, 2024. It is now read-only.
feat: add possibility to zoom the course workflow #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maximilian Hotter <Maxsiom@users.noreply.github.com>
Co-authored-by: Maximilian Hotter <Maxsiom@users.noreply.github.com>
It is now possible to zoom the course workflow with CTRL + MouseWheel in the Course Window.
Maxsiom
requested review from
Gusinuhe,
JulieAtInnoactive,
Luphoxa,
SimonTheSourcerer and
tomwim
SimonTheSourcerer
force-pushed
the
feature/ui-improvements
branch
from
72b9aa4 to
515e4e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I worked on the possibility to zoom the course workflow in the Course Window. First, I thought about manually scaling each single object. Since this needs a lot of rework in every rendering component, a global scaling value, and more work in future GUI components, I decided to find another solution.
Then I thought about GUI scaling. So I found a solution using the
GUI.matrix.It works pretty well but there are still to problems I did not find a proper solution yet:
The scrollbars do move when zooming. Tried to create manual ones but I did something wrong so it did not work out, unfortunately.
When zoomed the context menus are positioned wrongly. It uses
Event.current.mousePosition. I tried to overwrite it but it did not work out.I hope you can do something with this draft PR. 👍
Manual
Panning with middle mouse button.
Zooming with
CTRL+Mouse Wheel.Type of change