issue/834: add paged attention for nvidia gpu #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanZezhong1725
requested changes
Dec 24, 2025
| * This function initializes a descriptor that holds all the metadata needed | ||
| * for the paged attention computation. | ||
| * | ||
| * @param handle The handle to the InfiniOP library context. |
PanZezhong1725
requested changes
Dec 24, 2025
| // ----- Input Tensors ----- | ||
| const Tdata *k_ptr, // Pointer to the source Keys, shape [ntok, nkvh, dh] | ||
| const Tdata *v_ptr, // Pointer to the source Values, shape [ntok, nkvh, dh] | ||
| const int32_t *slot_mapping_ptr, // Pointer to the slot mapping, shape [ntok] |
Collaborator
There was a problem hiding this comment.
改成int64，或者最好使用template
PanZezhong1725
requested changes
Dec 24, 2025
| const Tdata *q_, | ||
| const Tdata *k_cache_, | ||
| const Tdata *v_cache_, | ||
| const int32_t *block_tables_, |
Collaborator
There was a problem hiding this comment.
用template或者更大的数据类型，int32容易溢出
| float scale) { | ||
|
|
||
| auto dtype = q_desc->dtype(); | ||
| CHECK_DTYPE(dtype, INFINI_DTYPE_F16, INFINI_DTYPE_BF16, INFINI_DTYPE_F32); |
Collaborator
There was a problem hiding this comment.
缺少block_tables_desc、seq_lens_desc的类型检查
PanZezhong1725
requested changes
Dec 24, 2025
| void *stream_) const { | ||
| cudaStream_t stream = (cudaStream_t)stream_; | ||
| if (_opaque->internal->maxThreadsPerBlock() == CUDA_BLOCK_SIZE_1024) { | ||
| if (_info.head_size == 128) { |
Collaborator
There was a problem hiding this comment.
如果计算时对head dim有要求，请在创建算子的描述时做检查
PanZezhong1725
requested changes
Dec 24, 2025
| const int seq_idx = blockIdx.y; | ||
| const int head_idx = blockIdx.x; | ||
| const int num_heads = gridDim.x; | ||
| const ptrdiff_t o_stride = q_stride / 3; // qkv |
PanZezhong1725
force-pushed
the
issue/834
branch
from
fb9bd9c to
9695b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python 测试截图：
