Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 12, 2025

  • Understand the changes from PR fix(calendar): fix date styles and formating #16618 (date styles and formatting fixes)
  • Create new file: day-digit.pipe.ts in the correct location for 20.1.x
  • Update days-view.component.html to use the dayDigit pipe
  • Update days-view.component.ts to import DayDigitPipe
  • Update days-view.component.spec.ts with the new test
  • Update calendar theme SCSS to add white-space: nowrap
  • Update calendar sample files to include formatViews and zh-CN locale
  • Build and test the changes (build successful, lint passed)
  • Run code review (passed with no comments)
  • Run security checks (no issues detected)
  • Revert unintended package.json change

Summary

Successfully cherry-picked all changes from PR #16618 to the 20.1.x branch. The changes fix date styles and formatting issues in the Calendar component, particularly for locales like zh-CN that include non-numeric characters in date formatting (e.g., "25日"). All files have been adapted to the 20.1.x directory structure, and the implementation maintains consistency with the original PR. Reverted the unintended addition of karma-jasmine-spec-tags to package.json.

Original prompt

Cherry-pick the changes from the merged pull request #16618 (fix(calendar): fix date styles and formatting) into the 20.1.x branch. Ensure all fixes for date styles and formatting in the Calendar component are accurately applied to maintain consistency across versions.

This pull request was created as a result of the following prompt from Copilot chat.

Cherry-pick the changes from the merged pull request #16618 (fix(calendar): fix date styles and formatting) into the 20.1.x branch. Ensure all fixes for date styles and formatting in the Calendar component are accurately applied to maintain consistency across versions.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…mponent

Co-authored-by: desig9stein <21260963+desig9stein@users.noreply.github.com>
@desig9stein desig9stein marked this pull request as ready for review December 12, 2025 12:31
Co-authored-by: desig9stein <21260963+desig9stein@users.noreply.github.com>
Copilot AI changed the title [WIP] Cherry-pick date styles and formatting fixes from PR #16618 Cherry-pick PR #16618: fix calendar date styles and formatting to 20.1.x Dec 12, 2025
Copilot AI requested a review from desig9stein December 12, 2025 12:41
@desig9stein
Copy link
Contributor

@copilot revert the change you made in the package.json file

Co-authored-by: desig9stein <21260963+desig9stein@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 16, 2025

@copilot revert the change you made in the package.json file

Reverted the karma-jasmine-spec-tags change in commit 02837b7.

@desig9stein desig9stein added the ✅ status: verified Applies to PRs that have passed manual verification label Dec 16, 2025
@desig9stein desig9stein removed their request for review December 16, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📆 calendar version: 20.1.x ✅ status: verified Applies to PRs that have passed manual verification ❌ status: awaiting-test PRs awaiting manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants