Fix branch naming with empty string

[H0ARK]

Summary

• handle empty strings in get_head_branch_name
• add regression test
• provide typing helper for override

Testing

• pytest tests/unit/codegen/runner/utils/test_branch_name.py::test_get_head_branch_name_empty_string (fails: cannot import name 'override' from 'typing')

---

https://chatgpt.com/codex/tasks/task_e_684d6b0004a4832ebf7d5729dd0e53bd

[gemini-code-assist]

Summary of Changes

Hello @H0ARK, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses an edge case in the branch naming utility to ensure robustness when handling empty string inputs. It also includes a necessary compatibility layer for the override typing decorator, resolving a reported test failure and preparing for broader usage of this feature.

Highlights

• Branch Naming Fix: The get_head_branch_name utility function now correctly treats an empty string ("") the same way it treats None, generating a default branch name in both cases. Previously, only None triggered the default name generation.
• Typing Compatibility: Introduced a new module typing_compat to provide a backward-compatible import for the typing.override decorator, supporting Python versions older than 3.12 by falling back to typing_extensions.
• Regression Test: Added a new unit test specifically for the get_head_branch_name function to ensure that passing an empty string results in a generated branch name.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR ensures that an empty branch_name is treated like None (generating a codegen-<uuid> name), adds a regression test for this case, and provides a compatibility shim for the override typing helper.

• Treat empty strings as missing branch names in get_head_branch_name
• Add a test to cover the empty-string branch-name scenario
• Add typing_compat.override fallback import for Python <3.12

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/unit/codegen/runner/utils/test_branch_name.py	Added test_get_head_branch_name_empty_string
src/codegen/shared/typing_compat.py	Introduced fallback import for override from typing_extensions
src/codegen/runner/utils/branch_name.py	Expanded get_head_branch_name to handle empty strings and added a docstring

Comments suppressed due to low confidence (3)

tests/unit/codegen/runner/utils/test_branch_name.py:31

• Consider also asserting that the generated name does not include the -group- suffix when group=None, e.g., assert "-group-" not in branch_name.

assert branch_name.startswith("codegen-")

src/codegen/shared/typing_compat.py:1

• It could be valuable to add a unit test for this file to verify that override is imported from typing when available and falls back to typing_extensions when not.

try:

src/codegen/runner/utils/branch_name.py:7

• [nitpick] The docstring could be extended to include parameter and return descriptions (e.g., explain branch_name, group, and the returned format).

"""Return a sanitized branch name for the PR head.

[gemini-code-assist]

Code Review

This PR correctly addresses handling empty branch names in get_head_branch_name and adds a necessary regression test. It also introduces a standard compatibility shim for typing.override.

The primary concern is the test failure cannot import name 'override' from 'typing' mentioned in the PR description. This likely indicates that typing_extensions is not available in the test environment for older Python versions. Please ensure typing_extensions is added as a project dependency to resolve this, allowing the fallback in typing_compat.py to function correctly.

The code changes within the diff appear sound and do not present issues of medium or higher severity.