Skip to content

Fixed Typo#4

Open
GlennBlake wants to merge 10 commits intomainfrom
assignment
Open

Fixed Typo#4
GlennBlake wants to merge 10 commits intomainfrom
assignment

Conversation

@GlennBlake
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2

Please address the issues listed above.

Copy link

@danielrazavi danielrazavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the code I see and the changes you made in each commit, I believe getting all checkmarks was well within your grasp. As my comment below indicates, I don’t understand why the code changes shown below were made for those specific lines, but those are the ones that resulted in the Xs. I recommend running more thorough tests on your code locally before submitting.

cp ./data/raw/rawdata/*server*.log ./data/processed/server_logs
cp *server*.log ./data/raw/ ./data/processed/server_logs/
# 6. Repeat the above step for user logs and event logs
cp ./data/raw/rawdata/*event*.log ./data/processed/event_logs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct code, why change it?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5 No server log files in data/raw
Part 1 - Q6 No user log files in data/raw; No event log files in data/raw
Part 1 - Q7
Part 1 - Q8
Part 2

Please address the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants