Need to review before merge from official. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 0d4dac2, we added a CSP address parameter to the csp_can_socketcan_open_and_add_interface() function. The address is assigned to ctx->iface.addr. This commit similarly adds an addr parameter for the CSP address to csp_usart_open_and_add_kiss_interface(), allowing us to specify the address for the given interface. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Previously, only the ZMQ interface was supported by default. This update introduces command line options for ZMQ. The `get_options()` function now supports `--zmq` as interface options. The server initialization and routing table setup have been updated to handle the selected interface based on the command line arguments provided. We just add zmq parameter to the server python binding example, so we also have to modify the current usage in the python workflow. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
This update introduces command line options for KISS. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Add command line parameter options for kiss to python version of client. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Fix camel case in python client example, `getOptions` to ``get_options``. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
In the previous commit, we added parameters to the server python binding example, in order to test that address parameter take the parameter and not the default value. I changed the address in zmq test to test the option parameter, introduce by previous commit. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
In the previous commit, we add kiss parameter to the server python binding example, so we also have to modify the python workflow to be able to test kiss interface as well. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Added steps to set up a virtual CAN (vcan0) interface in the CI environment. Included tests for the CAN interface using the `csp_server` and `csp_client` examples. Ensured the CAN interface is correctly configured with `modprobe vcan`and `ip link add dev vcan0 type vcan`. Implemented both server and client tests to validate CAN communication. This change enables automated testing of the CAN interface within the CI pipeline, improving test coverage for CAN-related functionality. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
The `csp_rdp_conn_print` function has no implementation, documentation, or usage. This commit removes its declaration.
When `__csp_rdp_queue_flush` encounters an empty queue (i.e., `csp_queue_size(queue) == 0`), the function would return an undefined value due to the uninitialized variable `ret`. This commit resolves the issue by initializing `ret` to `CSP_ERR_NONE`. `CSP_ERR_NONE` is a suitable value since an empty queue is equivalent to a successfully flushed queue. Although the return value is not currently used, this change ensures future robustness if the return value is utilized later.
This commit changes the scope of `qfifo_queue_buffer` from global to local. There appears to be no clear reason for exposing the internal implementation details of the queue.
Update the code to capture the return value of `csp_iflist_add` in the variable `ret`. This allows for proper error handling by ensuring that the result of `csp_iflist_add` is returned by the function. Previously, the return value was ignored, which could lead to missing error information. The return value is now used to confirm successful interface addition, and if an error occurs, it can be properly propagated. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Added a line to increment the `drop` counter on the KISS interface when a frame is lost due to overflow. This ensures that frame loss is properly tracked. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Adds 'csp_if_eth.c' and 'csp_if_eth_pbuf.c' to the cmake build process.
Replacing the usage of printf with csp_printf since not all platforms have direct support for printf.
Adds 'eth_linux.c' to the cmake build.
Replacing the usage of printf with csp_printf since not all platforms have direct support for printf. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Replacing the usage of printf with csp_printf since not all platforms have direct support for printf. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Replacing the usage of printf with csp_printf since not all platforms have direct support for printf. Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
Fix wrong order of input parameters to '__csp_rdp_queue_flush()'.
|
Hello, my name is Namthip.
|
Member
Author
|
Hi @ttip-ts , Thank you for your report.
BTW, To avoid complex analysis and multi-issues on a comment |
|
Hi Mr.Anol @Apaisal I clicked to shut down the laptop, and the YAMCS web page disconnected. |
Member
Author
|
Hi @ttip-ts
This is very sensitive information, Please take a look the default password from community.
This scenario related YAMCS. Please see YAMCS repository for learning. BTW, please discuss on CRA-AIIM backlog at CRA-AIIM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local develop branch sync with official on 20240911
and need to review before merge into next aiim version.