Open
Conversation
…shell/git assignment.
…into assignment
…tionally removed rf -rf ./data line of code that was included when merged updates with coworkers. This was potentially added in error my another student.
Autograder results
|
|
Assignment marked complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Here, I added code to the assignment.sh file to complete the instructions written in this file. These lines of code created necessary directories and populated these directories with files as per the instructions. My code further removed unnecessary files and created an inventory of the files within the newly created directories. Next, I merged these changes with "coworker changes" in the main DSI repository and confirmed that the "coworker changes" did not affect the output of the code. Following merging, I removed an erroneous line of code that had been included by a coworker and was not associated with a known command.
What did you learn from the changes you have made?
From the changes I made, I gained a better understanding on how to apply the wildcard symbol to easily extract files with certain patterns and cp/move them around directories. I also learned the importance of checking co-worker changes and making sure they are actually accurate rather than just assuming that any changes made are correct.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
For the last instruction of the assignment (Instruction 8), I considered an alternative way of listing the files in inventory.txt that only required one line of code and that organized the files within the inventory.txt file. This is done by including the three directories one after the other in the ls command and then appending them to the inventory.txt file. I included this method in my assignment as a commented out line.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The only challenge that I faced was that I changed the branch name of my assignment branch on github after I had cloned it to my computer. This made it difficult to commit and sync my changes. I investigated whether there was a way to change the branch name on my local cloned repository and was able to do so, but the sync still didn't work. Ultimately, I just deleted the incorrectly cloned repository from my local computer and re-cloned it with the corrected name.
How were these changes tested?
I tested the changes I made as well as the fixes I made following merging by running the assignment.sh script from another location in my computer and confirming that all functions were performed correctly.
A reference to a related issue in your repository (if applicable)
NA
Checklist