Week03 #3
Week03 #3
Conversation
mattiaslundberg
left a comment
mattiaslundberg
left a comment
There was a problem hiding this comment.
Added some pointers!
Don't forget the step to move to classes later.
| window.onload = () => main(HYF_REPOS_URL); | ||
| } | ||
| jsonData.forEach(contributor => { | ||
| createAndAppend('div', contribs, { text: contributor.login, class: 'contributor' }) |
There was a problem hiding this comment.
contribs here isn't what you expect. It's the promise from line 63 and not the dom-element from line 35, you need to get it from the dom again (like you do on line 35) and use it in this function.
There was a problem hiding this comment.
I changed this. but now the contrinutors_url is undefined!
There was a problem hiding this comment.
Not related! Have a look at how you call getContributorInformation and what arguments it requires
There was a problem hiding this comment.
I think I get your point. I forgot to put the argument 'data' in the getContributorInformation function.
I should figure out what to put there !
mattiaslundberg
left a comment
mattiaslundberg
left a comment
There was a problem hiding this comment.
The async/await rewrite looks good! You also have to do the rewrite with classes to pass week 3, let me know if you need any assistance!
No description provided.