use the usual package output directory for build summary#238
Open
chouquette wants to merge 2 commits intodatadog-5.5.0from
Open
use the usual package output directory for build summary#238chouquette wants to merge 2 commits intodatadog-5.5.0from
chouquette wants to merge 2 commits intodatadog-5.5.0from
Conversation
This simplifies things for windows where we are currently outputing the summary into the sources location instead of the usual output one. No change is expected on linux where the package_dir is a subdirectory of the project_root
chouquette
force-pushed
the
chouquette/build-summary
branch
from
da90da0 to
d867df5
Compare
alopezz
requested changes
Jul 24, 2025
alopezz
left a comment
alopezz
left a comment
There was a problem hiding this comment.
The downstream pipeline (on datadog-agent) is red, all package build jobs are failing. I'd need to look again in detail, but I suspect that this requires changes in datadog-agent w.r.t. the assumptions around where this build summary file is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies things for windows where we are currently outputing the summary into the sources location instead of the usual output one. No change is expected on linux where the package_dir is a subdirectory of the project_root