Remove Rosetta Installer requirement via hostArchitectures fix#155
Open
timsutton wants to merge 2 commits intoDataDog:datadog-5.5.0from
Open
Remove Rosetta Installer requirement via hostArchitectures fix#155timsutton wants to merge 2 commits intoDataDog:datadog-5.5.0from
timsutton wants to merge 2 commits intoDataDog:datadog-5.5.0from
Conversation
Unless hostArchitectures is set, macOS 11 will assume that the package is x86_64 and require Rosetta 2. * https://scriptingosx.com/2020/12/platform-support-in-macos-installer-packages-pkg/ * https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html#//apple_ref/doc/uid/TP40005370-CH100-SW7 Signed-off-by: Tom Duffield <tom@chef.io>
timsutton
changed the title
Closed
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-picked cf9d133 plus the needed helper method to return
safe_architecture. This is what is needed to prevent the package installation itself from requiring Rosetta (and actually switching the Installer to a mode where it runs in Rosetta mode). Without this change, Rosetta is prompted for even if all the files are arm64-only.If it's preferable I can try to bring all of chef#1002 in, I just didn't because of more conflicts to fix and wasn't sure if some of the version + pkg path changes cause more issues for this fork's maintainers. It is very diverged from chef's repo so I'm not sure how maintainers prefer to handle this.