Skip to content

Conversation

@gabedos
Copy link
Contributor

@gabedos gabedos commented Dec 5, 2025

What does this PR do?

This PR fixes an issue where the remote tagger could enter a tight retry loop when authentication fails, flooding the logs with "error received from remote tagger" messages.

Previously, the exponential backoff was only applied to the initial connection attempt (startTaggerStream). If the connection succeeded but the subsequent Recv() call immediately failed (e.g., due to an invalid session token), the outer loop would retry immediately without backing off.

This change refactors remoteTagger.run to share a single exponential backoff timer for both connection and stream reception. This ensures that any failure in the stream—whether during connection or initial data reception—triggers a proper backoff delay.

Motivation

Manage edge cases where remote tagger stream is considered initialized but is in a bad state and throws errors when attempting to receive any events.

CONTP-938

Describe how you validated your changes

This condition occurs during Agent misconfigurations as well as during DCA/CLC rollouts.

Deploy the following helm chart.

datadog:
  logLevel: Warn
  kubelet:
    tlsVerify: false

clusterAgent:
  enabled: true

clusterChecksRunner:
  enabled: true
  readinessProbe:
    initialDelaySeconds: 90

Note, the readinessProbe initialDelaySeconds is not required to have the error, but it does give us a longer window to see it. One case where the issue occurs is when CLC runners from the old deployment are still lingering around (for any reason, but in case bc of the readiness probe). The old CLC runners won't have the proper tokens to communicate to the DCA because a new one is generated for each helm install.

Thus, when you re-apply the helm chart a second time to trigger a deployment, you should see in your old containers the logs error received from remote tagger: ....

With the old Agent, you should see thousands of logs per minute. With the new Agent, you should see a few logs every few seconds as noted below:

2025-12-05 14:44:54 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:44:55 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:44:57 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:44:59 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:44:59 UTC | CORE | INFO | (comp/core/agenttelemetry/impl/agenttelemetry.go:508 in run) | Starting agent telemetry run
2025-12-05 14:45:03 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:45:04 UTC | CORE | INFO | (pkg/api/security/security.go:178 in getClusterAgentAuthToken) | Using configured cluster_agent.auth_token
2025-12-05 14:45:04 UTC | CORE | ERROR | (comp/core/autodiscovery/autodiscoveryimpl/config_poller.go:152 in poll) | Cache processing of cluster-checks configuration provider failed: temporary failure in clusterAgentClient, will retry later: "https://10.97.37.236:5005/version" is unavailable: 403 Forbidden
2025-12-05 14:45:04 UTC | CORE | ERROR | (comp/core/autodiscovery/autodiscoveryimpl/autoconfig.go:174 in func1) | Workloadmeta collectors are not ready after 19 retries: workloadmeta not initialized, starting check scheduler controller anyway.
2025-12-05 14:45:04 UTC | CORE | INFO | (comp/core/autodiscovery/scheduler/controller.go:88 in Start) | Autodiscovery scheduler controller started
2025-12-05 14:45:07 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:45:10 UTC | CORE | INFO | (comp/forwarder/defaultforwarder/transaction/transaction.go:460 in internalProcess) | Successfully posted payload to "https://7-75-0-app.agent.datadoghq.com./api/v1/check_run" (202 Accepted), the agent will only log transaction success every 500 transactions
2025-12-05 14:45:11 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:45:14 UTC | CORE | INFO | (pkg/api/security/security.go:178 in getClusterAgentAuthToken) | Using configured cluster_agent.auth_token
2025-12-05 14:45:14 UTC | CORE | ERROR | (comp/core/autodiscovery/autodiscoveryimpl/config_poller.go:152 in poll) | Cache processing of cluster-checks configuration provider failed: temporary failure in clusterAgentClient, will retry later: "https://10.97.37.236:5005/version" is unavailable: 403 Forbidden
2025-12-05 14:45:18 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token
2025-12-05 14:45:19 UTC | CORE | WARN | (comp/core/autodiscovery/providers/clusterchecks.go:211 in heartbeatSender) | Unable to send extra heartbeat to Cluster Agent, err: DCA Client not initialized by main provider yet, cannot post heartbeat, wait for init completion
2025-12-05 14:45:24 UTC | CORE | INFO | (comp/core/agenttelemetry/impl/agenttelemetry.go:508 in run) | Starting agent telemetry run
2025-12-05 14:45:24 UTC | CORE | INFO | (pkg/api/security/security.go:178 in getClusterAgentAuthToken) | Using configured cluster_agent.auth_token
2025-12-05 14:45:24 UTC | CORE | ERROR | (comp/core/autodiscovery/autodiscoveryimpl/config_poller.go:152 in poll) | Cache processing of cluster-checks configuration provider failed: temporary failure in clusterAgentClient, will retry later: "https://10.97.37.236:5005/version" is unavailable: 403 Forbidden
2025-12-05 14:45:34 UTC | CORE | INFO | (pkg/api/security/security.go:178 in getClusterAgentAuthToken) | Using configured cluster_agent.auth_token
2025-12-05 14:45:34 UTC | CORE | ERROR | (comp/core/autodiscovery/autodiscoveryimpl/config_poller.go:152 in poll) | Cache processing of cluster-checks configuration provider failed: temporary failure in clusterAgentClient, will retry later: "https://10.97.37.236:5005/version" is unavailable: 403 Forbidden
2025-12-05 14:45:36 UTC | CORE | WARN | (comp/core/tagger/impl-remote/remote.go:522 in run) | error received from remote tagger: rpc error: code = Unauthenticated desc = invalid auth token: Invalid session token

Additional Notes

#41404

CONS-7564

[CONS-7889]

@gabedos gabedos requested review from a team as code owners December 5, 2025 15:00
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team labels Dec 5, 2025
@gabedos gabedos added the qa/done QA done before merge and regressions are covered by tests label Dec 5, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 5, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b39a5d3

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${705.48}$$ < $${706.32}$$ $${-0.08}$$ $${172.85}$$ < $${173.81}$$
agent_deb_amd64_fips $${+0.01}$$ $${700.82}$$ < $${701.16}$$ $${+0}$$ $${171.83}$$ < $${172.71}$$
agent_heroku_amd64 $${+0}$$ $${327.26}$$ < $${327.69}$$ $${-0}$$ $${87.23}$$ < $${88.19}$$
agent_msi $${+0.03}$$ $${568.86}$$ < $${982.08}$$ $${+0.01}$$ $${141.75}$$ < $${143.01}$$
agent_rpm_amd64 $${-0}$$ $${705.46}$$ < $${706.31}$$ $${+0.02}$$ $${175.93}$$ < $${176.86}$$
agent_rpm_amd64_fips $${+0.01}$$ $${700.8}$$ < $${701.15}$$ $${+0.03}$$ $${173.98}$$ < $${174.95}$$
agent_rpm_arm64 $${-0}$$ $${691.13}$$ < $${691.67}$$ $${+0.02}$$ $${159.72}$$ < $${160.7}$$
agent_rpm_arm64_fips $${+0}$$ $${687.35}$$ < $${687.54}$$ $${-0.04}$$ $${159.16}$$ < $${160.1}$$
agent_suse_amd64 $${-0}$$ $${705.46}$$ < $${706.31}$$ $${+0.02}$$ $${175.93}$$ < $${176.86}$$
agent_suse_amd64_fips $${+0.01}$$ $${700.8}$$ < $${701.15}$$ $${+0.03}$$ $${173.98}$$ < $${174.95}$$
agent_suse_arm64 $${-0}$$ $${691.13}$$ < $${691.67}$$ $${+0.02}$$ $${159.72}$$ < $${160.7}$$
agent_suse_arm64_fips $${+0}$$ $${687.35}$$ < $${687.54}$$ $${-0.04}$$ $${159.16}$$ < $${160.1}$$
docker_agent_amd64 $${-0}$$ $${767.8}$$ < $${768.66}$$ $${+0}$$ $${260.63}$$ < $${261.52}$$
docker_agent_arm64 $${-0}$$ $${777.75}$$ < $${778.35}$$ $${+0}$$ $${250.8}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${-0}$$ $${958.68}$$ < $${959.54}$$ $${+0.01}$$ $${329.27}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${-0}$$ $${957.35}$$ < $${957.95}$$ $${+0.02}$$ $${315.43}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${179.11}$$ < $${179.28}$$ $${-0}$$ $${63.24}$$ < $${63.96}$$
docker_cluster_agent_arm64 $${-0}$$ $${196.58}$$ < $${196.79}$$ $${+0}$$ $${59.98}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${+0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.66}$$ < $${39.3}$$ $${0}$$ $${14.93}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.36}$$ < $${37.94}$$ $${-0}$$ $${14.38}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.88}$$ < $${30.53}$$ $${+0}$$ $${7.88}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.4}$$ < $${29.11}$$ $${-0}$$ $${6.82}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.88}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.88}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
iot_agent_deb_amd64 $${+0.01}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.13}$$ < $${11.98}$$
iot_agent_deb_arm64 $${+0.01}$$ $${40.36}$$ < $${40.92}$$ $${-0}$$ $${9.58}$$ < $${10.45}$$
iot_agent_deb_armhf $${+0}$$ $${40.26}$$ < $${40.86}$$ $${+0}$$ $${9.7}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${+0.01}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.15}$$ < $${12.0}$$
iot_agent_suse_amd64 $${+0.01}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.15}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 5, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8d36aa84-16eb-40e7-b221-ae5fa4fbf95f

Baseline: 47d7d4e
Comparison: 11a759d
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.84 [-3.81, +2.13] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +1.49 [+0.91, +2.06] 1 Logs
quality_gate_metrics_logs memory utilization +0.62 [+0.40, +0.84] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.36 [+0.32, +0.41] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.28 [+0.18, +0.38] 1 Logs
ddot_logs memory utilization +0.24 [+0.16, +0.31] 1 Logs
quality_gate_logs % cpu utilization +0.17 [-1.32, +1.66] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.16 [-0.07, +0.40] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.16 [+0.00, +0.32] 1 Logs
docker_containers_memory memory utilization +0.08 [+0.00, +0.16] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.07 [+0.02, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.36, +0.40] 1 Logs
ddot_metrics_sum_delta memory utilization +0.01 [-0.20, +0.22] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.07] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.44, +0.40] 1 Logs
ddot_metrics memory utilization -0.05 [-0.26, +0.16] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.45, +0.34] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.06 [-0.12, -0.00] 1 Logs
quality_gate_idle_all_features memory utilization -0.07 [-0.11, -0.03] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.18 [-0.33, -0.03] 1 Logs
otlp_ingest_logs memory utilization -0.34 [-0.44, -0.23] 1 Logs
docker_containers_cpu % cpu utilization -0.84 [-3.81, +2.13] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gabedos
Copy link
Contributor Author

gabedos commented Dec 12, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 12, 2025

View all feedbacks in Devflow UI.

2025-12-12 15:37:05 UTC ℹ️ Start processing command /merge


2025-12-12 15:37:13 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-12-12 18:14:52 UTC ⚠️ MergeQueue: This merge request was unqueued

gabe.dossantos@datadoghq.com unqueued this merge request

@gabedos
Copy link
Contributor Author

gabedos commented Dec 12, 2025

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 12, 2025

View all feedbacks in Devflow UI.

2025-12-12 18:14:48 UTC ℹ️ Start processing command /remove


2025-12-12 18:14:51 UTC ℹ️ Devflow: /remove

@gabedos
Copy link
Contributor Author

gabedos commented Dec 12, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 12, 2025

View all feedbacks in Devflow UI.

2025-12-12 21:06:00 UTC ℹ️ Start processing command /merge


2025-12-12 21:06:05 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 40m (p90).


2025-12-12 21:49:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c02aa45 into main Dec 12, 2025
301 checks passed
@dd-mergequeue dd-mergequeue bot deleted the gabedos/remote-tagger-backoff branch December 12, 2025 21:49
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants