[ABLD-278] Use bazel built libacl. (#44079)

Cutover from omnibus libacl to bazel

- Call libacl install directly from openscap.rb. When openscap is built with Bazel, we'll just depend on it as a dependency.
- Remove omnibus step for libacl
- Adjust build flags to match what configure/make would produce. 

### Testing:

- Compare 3 things
  - build with with configure/make,
  - pull libacl.so from an old CI image,
  - build with bazel and look at libacl.so

The sizes are close enough for comfort. They vary a bit because in the new build we are not double building some util functions, so we get a little space back.

Similar compare for the public header files.  Make sure that our new ones match previous agent builds.


Co-authored-by: tony.aiuto <tony.aiuto@datadoghq.com>

Author: aiuto

deps/acl/overlay/overlay.BUILD.bazel

@@ -1,22 +1,20 @@
-# libacl
+"""libacl"""
 
 load("@@//bazel/rules:so_symlink.bzl", "so_symlink")
 load("@@//compliance/rules:ship_source_offer.bzl", "ship_source_offer")
-load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
 load("@package_metadata//rules:package_metadata.bzl", "package_metadata")
 load("@rules_cc//cc:defs.bzl", "cc_library", "cc_shared_library")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files", "strip_prefix")
 
 package(default_package_metadata = [":package_metadata", ":ship_source_offer"])
 
-_VERSION = "2.3.1"
+VERSION = "2.3.1"
 
-# This is going to change in the future. Debate the syntax in https://github.com/bazel-contrib/supply-chain/issues/124
-PURL = "pkg:https/download.savannah.nongnu.org/acl@{version}?url=https://download.savannah.nongnu.org/releases/acl/attr-%{version}.tar.xz".format(
-    version = _VERSION,
+PURL = "pkg:generic/acl@{version}?download_url=https://download.savannah.nongnu.org/releases/acl/acl-{version}.tar.xz".format(
+    version = VERSION,
 )
 
 package_metadata(
@@ -39,33 +37,39 @@ license(
 
 # TODO: We will have to adjust this when we put a dependency on it.
 # It is possible that some of the other files in include are public.
-_PUBLIC_HEADERS = [
-    ":include/sys/acl.h",
-    ":include/acl/libacl.h",
+PUBLIC_HEADERS = [
+    ":fixed/include/sys/acl.h",
+    ":fixed/include/acl/libacl.h",
 ]
 
-# The code sometimes includes "include/acl.h" as <sys/acl.h>
-copy_file(
-    name = "sys_acl_h",
-    src = "include/acl.h",
-    out = "include/sys/acl.h",
-)
+# There are two things going on here
+# 1. The public headers in the source are not in their installed locations.
+#    src = "include/acl.h" => "include/sys/acl.h"
+#    src = "include/libacl.h",  => "include/acl/libacl.h"
+# 2. In the (internal) source headers, external methods are marked EXPORT.
+#    However, the public version should use extern instead. Configure/make
+#    did the rename while copying, so we do the same.
 
-# There is both a libacl/libacl.h and an include/libacl.h
-# libacl/libacl.h is internal to the library build.
-# include/libacl.h is the public one, which they self refernce as
-#   <sys/libacl.h>
-copy_file(
-    name = "sys_libacl_h",
-    src = "include/libacl.h",
-    out = "include/acl/libacl.h",
+genrule(
+    name = "fixed_headers",
+    srcs = [
+        ":include/acl.h",
+        ":include/libacl.h",
+    ],
+    outs = [
+        "fixed/include/sys/acl.h",
+        "fixed/include/acl/libacl.h",
+    ],
+    cmd = ";".join([
+        "sed 's/EXPORT/extern/g' $(location :include/acl.h) > $(location fixed/include/sys/acl.h)",
+        "sed 's/EXPORT/extern/g' $(location :include/libacl.h) > $(location fixed/include/acl/libacl.h)",
+    ]),
 )
 
 cc_library(
     name = "libacl",
     srcs = [
-        ":sys_acl_h",
-        ":sys_libacl_h",
+        ":fixed_headers",
         "include/acl_ea.h",
         "include/acl.h",
         "include/config.h",
@@ -133,14 +137,15 @@ cc_library(
         "libmisc/unquote.c",
         "libmisc/walk_tree.c",
     ],
-    hdrs = _PUBLIC_HEADERS,
+    hdrs = PUBLIC_HEADERS,
     includes = [
         "include",
+        "fixed/include",
     ],
     copts = [
         "-fPIC",
-        # TODO: Does this need speed or size?
-        # "-O2",
+        "-O2",
+        "-g",
         "-Ilibacl",
     ],
     local_defines = [
@@ -173,12 +178,14 @@ so_symlink(
     src = ":acl",
     libname = "libacl",
     version = "1.1.2301",
+    prefix = "embedded",
 )
 
 pkg_files(
     name = "hdr_files",
-    srcs = _PUBLIC_HEADERS,
-    prefix = "include/acl/",
+    srcs = [":fixed_headers"],
+    strip_prefix = strip_prefix.from_pkg("fixed"),
+    prefix = "embedded",
 )
 
 expand_template(
@@ -190,22 +197,29 @@ expand_template(
         "@exec_prefix@": "${prefix}",
         "@libdir@": "${prefix}/lib",
         "@includedir@": "${prefix}/include",
-        "@PACKAGE_VERSION@": _VERSION,
+        "@PACKAGE_VERSION@": VERSION,
     },
     template = "libacl.pc.in",
 )
 
 pkg_files(
     name = "pc_file",
     srcs = [":gen_pkgconfig"],
-    prefix = "lib/pkgconfig",
+    prefix = "embedded/lib/pkgconfig",
 )
 
-pkg_install(
-    name = "install",
+pkg_filegroup(
+    name = "all_files",
     srcs = [
         ":hdr_files",
         ":lib_files",
         ":pc_file",
     ],
 )
+
+pkg_install(
+    name = "install",
+    srcs = [
+        ":all_files",
+    ],
+)

omnibus/config/software/libacl.rb

@@ -15,11 +15,17 @@
 
 source url: "https://github.com/OpenSCAP/openscap/releases/download/#{version}/openscap-#{version}.tar.gz"
 
+build do
+  command_on_repo_root "bazelisk run -- @acl//:install --destdir='#{install_dir}'"
+  command_on_repo_root "bazelisk run -- //bazel/rules:replace_prefix --prefix '#{install_dir}/embedded'" \
+    " #{install_dir}/embedded/lib/pkgconfig/libacl.pc" \
+    " #{install_dir}/embedded/lib/libacl.so"
+end
+
 dependency 'attr'
 dependency 'bzip2'
 dependency 'curl'
 dependency 'dbus'
-dependency 'libacl'
 dependency 'libgcrypt'
 dependency 'libselinux'
 dependency 'libsepol'