London | 25-SDC-Nov | Emiliano Uruena | Sprint 5 | Laptops Allocation by Emilianouz · Pull Request #307 · CodeYourFuture/Module-Tools

Emilianouz · 2025-12-18T16:17:33Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Implementing Laptop allocation exercise.

github-actions · 2025-12-18T16:17:54Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-12-18T16:18:12Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-12-18T16:18:21Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Emilianouz · 2026-02-16T12:20:28Z

README file no necessary. It was removed.

SlideGauge · 2026-02-23T22:37:40Z

Made review, interesting approach but there are some errors in the implementation itself worthy fixing + the algorithm won't find the most minimal possible configuration

Implement calcutate_sandess and backtracking for laptop allocation based on user preferences and minimize sadness.

OracPrime · 2026-02-28T18:00:41Z

I'll leave @SlideGauge to carry on with this since he's most recent reviewer

SlideGauge

Overall really good solution, please change the returning type of the function and I will mark the review as complete.

SlideGauge · 2026-02-23T22:14:13Z

laptop-allocation.py

+            for laptop in laptops:
+                if (laptop.operating_system == os and not laptop.assigned):
+                    allocation[person.name] = laptop.id
+                    assigned = True


Does this assigned variable prevent us from selecting the same laptop several times?

SlideGauge · 2026-02-23T22:20:20Z

laptop-allocation.py

+                    allocation[person.name] = laptop.id
+                    assigned = True
+                    break
+            if assigned:


what happens if we did not found the laptop after the first loop
for laptop in laptops?

SlideGauge · 2026-02-23T22:20:59Z

laptop-allocation.py

+                    allocation[person.name] = laptop.id
+                    assigned = True
+                    break
+            if assigned:


if assigned was set to True, what happens after iterating the first os?

SlideGauge · 2026-02-23T22:25:35Z

laptop-allocation.py

+    operating_system: OperatingSystem
+    assigned: bool = False
+
+def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> Dict[str, int]:


The algorithm belongs to the type of algorithms called "Greedy", i.e. on each step the algorithm takes the most suitable choice seen at this moment, not globally.
Consider:
Imran wants UBUNTU, ARCH
Eliza wants UBUNTU

The algorithm will give UBUNTU to Imran and nothing to Eliza, leading to sadness 100.

But we can invent different algorithm: if we distribute UBUNTU to Eliza and ARCH to Imran, we will have sadness 1. This algorithm will be slower, but our task is not to create the quickest algorithm, but minimizing the sadness.

Hint: this task requires analyzing of all possible permutations of laptops distribution.

SlideGauge · 2026-02-23T22:26:42Z

laptop-allocation.py

+    name: str
+    age: int
+    preferred_operating_system: List[OperatingSystem]
+    assigned_laptop: Optional[int] = None


Since the dataclass is frozen, we won't be able to change the value of this variable

SlideGauge · 2026-03-01T15:37:21Z

laptop-allocation.py

+        return person.preferred_operating_system.index(laptop.operating_system)
+    return 100
+
+def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> Dict[str, int]:


Really nice, yes, backtrack will solve the task.

SlideGauge · 2026-03-01T15:42:14Z

laptop-allocation.py

+        return person.preferred_operating_system.index(laptop.operating_system)
+    return 100
+
+def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> Dict[str, int]:


One thing to take into account:
the task demands us for the function to have this signature:
def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> Dict[Person, Laptop]:
Note, we return Dict of Person->Laptop, not str->int. It is valuable to take into account, as if we just return str->int, we won't be able to distinguish to people with the same name.

Right. We should return Dict[Person, Laptop] so people with the same name are handled correctly.

…on: Person and Laptop objects Change allocation function to change the returning type of the function: Person and Laptop objects

Emilianouz · 2026-03-01T22:06:22Z

@SlideGauge , I changed it to return type of the function: Person and Laptop objects. Thank you

SlideGauge · 2026-03-02T09:32:40Z

Very nice, thank you, accepted

Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 5 Assigned during Week 5 of this module labels Dec 18, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 18, 2025

Emilianouz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 18, 2025

laptop allocation exercise

964c731

Emilianouz force-pushed the Sprint5-Laptop branch from 6f464c6 to 964c731 Compare February 16, 2026 12:18

Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 16, 2026

Add sadness calculator and backtracking for laptop allocation

176ec47

Implement calcutate_sandess and backtracking for laptop allocation based on user preferences and minimize sadness.

Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 25, 2026

OracPrime requested a review from SlideGauge February 28, 2026 18:01

SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Mar 1, 2026

SlideGauge reviewed Mar 1, 2026

View reviewed changes

Change allocation function to change the returning type of the functi…

1a6fb3b

…on: Person and Laptop objects Change allocation function to change the returning type of the function: Person and Laptop objects

Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 1, 2026

SlideGauge added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026

Uh oh!

Conversation

Emilianouz commented Dec 18, 2025

Changelist

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

Emilianouz commented Feb 16, 2026

Uh oh!

SlideGauge commented Feb 23, 2026

Uh oh!

OracPrime commented Feb 28, 2026

Uh oh!

SlideGauge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Emilianouz commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SlideGauge commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Emilianouz commented Mar 1, 2026 •

edited

Loading