London | 26-ITP-January | Khaliun Baatarkhuu | Sprint 3 | Implement and rewrite tests.#1171
Open
khaliun-dev wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
Conversation
Implemented the getAngleType function to determine angle types and added tests for various cases.
Implement getCardValue function to determine card value based on rank and suit, including error handling for invalid cards.
Added checks for zero denominator and updated test cases for proper fractions.
khaliun-dev
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed all the exercises in implement and rewrite, and performed the necessary tests.
Questions
None so far.