Skip to content

London | 25-SDC-NOV | Fatma Degirmenci| Sprint 2 | Implement an LRU cache in Python#148

Open
fatmaevin wants to merge 1 commit intoCodeYourFuture:mainfrom
fatmaevin:implement_lru_cache
Open

London | 25-SDC-NOV | Fatma Degirmenci| Sprint 2 | Implement an LRU cache in Python#148
fatmaevin wants to merge 1 commit intoCodeYourFuture:mainfrom
fatmaevin:implement_lru_cache

Conversation

@fatmaevin
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented an LRU Cache in Python using OrderedDict.

@fatmaevin fatmaevin added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean implementation! Great job!

I think the code could benefit from some comments.
Could you use docstrings and inline comments to make the code a bit easier to understand.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants