London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 2 | Implement a linked list in python#146
Open
aydaeslami wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Conversation
aydaeslami
added
📅 Sprint 2
cjyuan
reviewed
Mar 2, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
The code in linked_list_test.py expects both .next and .previous properties of the removed node to be assigned None. Currently your implementation could not pass the tests.
Note: Do you know the why it is a good practice to assign .next and .previous of the removed node to None?
Comment on lines
+31
to
+36
| if self.tail.previous: | ||
| self.tail = self.tail.previous | ||
| self.tail.next = None | ||
| else: | ||
| self.head = None | ||
| self.tail = None |
There was a problem hiding this comment.
Could consider delegating the node removing task to remove() -- less code to maintain.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implemented a doubly linked list supporting push_head, pop_tail, and remove operations in O(1) time.