London | 25-SDC-NOV | Jesus del Moral | Sprint 2 | LRU Cache

[delmorallopez]

LRU Cache

[cjyuan]

To better adhere to the Single-Responsibility Principle (SRP) from SOLID design principles,
it's preferable to implement the "doubly linked list" and the "LRU Cache" as separate classes, with the linked list used inside LruCache to manage ordering.
In fact, you can import your LinkedList class from the other exercise, and then store each key-value pairs as a tuple.

Alternatively, you can use OrderedDict directly within LruCache to maintain order.

Could you update your code using one of these approaches?

[delmorallopez]

I updated the implementation using OrderedDict as suggested. This approach simplifies the code and better follows the Single-Responsibility Principle, since order maintenance is handled by OrderedDict rather than a custom linked list.

The cache now:

• storing key-value pairs in OrderedDict, which preserves insertion order
• moving accessed or updated items to the end to mark them as most recently used
• evicting the least recently used item (the first entry) when the limit is reached
• providing O(1) get and set operations
  This removes the need for manual node management and linked list logic, making the code cleaner and easier to maintain while still satisfying LRU behavior.

[cjyuan]

It seems a merge conflict has not yet been properly resolved.

[cjyuan]

Changes look good.

[cjyuan]

OrderedDict has a built-in method that can replace these two operations.