generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 28
London | 25-SDC-NOV | Jesus del Moral | Sprint 2 | Implement Linked List #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
delmorallopez
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
delmorallopez:complexity-Sprint2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| class Node: #A node in a doubly linked list | ||
| def __init__(self, value): #Initialize a new node with the given value and no next or previous nodes | ||
| self.value = value | ||
| self.previous = None | ||
| self.next = None | ||
|
|
||
|
|
||
| class LinkedList: # A doubly linked list data structure | ||
| def __init__(self): # Initialize an empty linked list with no head node | ||
| self.head = None | ||
| self.tail = None | ||
|
|
||
| def push_head(self, value): # Add a new node with the given value to the head of the list | ||
| new_node = Node(value) # Create a new node with the given value | ||
|
|
||
| new_node.next = self.head # Set the new node's next pointer to the current head of the list | ||
| if self.head: # If the list is not empty, set the current head's previous pointer to the new node | ||
| self.head.previous = new_node | ||
| else: | ||
| self.tail = new_node | ||
|
|
||
| self.head = new_node # Update the head of the list to be the new node | ||
| return new_node # Return node for O(1) removal later | ||
|
|
||
| def remove(self, node): # Remove the given node from the list | ||
| if node.previous: | ||
| node.previous.next = node.next | ||
| else: | ||
| # Removing head | ||
| self.head = node.next | ||
|
|
||
| if node.next: | ||
| node.next.previous = node.previous | ||
| else: | ||
| # Removing tail | ||
| self.tail = node.previous | ||
|
|
||
| # Clean up references | ||
| node.previous = None | ||
| node.next = None | ||
|
|
||
| def pop_tail(self): | ||
| if not self.tail: | ||
| return None | ||
|
|
||
| old_tail = self.tail | ||
| value = old_tail.value | ||
|
|
||
| self.remove(old_tail) # handles pointer updates + cleanup | ||
|
|
||
| return value | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import unittest | ||
|
|
||
| from linked_list import LinkedList | ||
|
|
||
| class LinkedListTest(unittest.TestCase): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not also clean up references in this method?
Could consider delegating the node removing task to
remove()-- less code to maintain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delegating to remove() would definitely reduce duplication and keep the logic in one place. It would make the implementation cleaner and easier to maintain, since any changes to the removal logic would only need to be made in a single method.
Delegating to remove(old_tail) does include the cleanup references because remove() method already does this