London | 25-SDC-Nov | Emiliano Uruena | Sprint 2 | LRU-cache Python

[Emilianouz]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Implement LRU Cache functionality.

[cjyuan]

To better adhere to the Single-Responsibility Principle (SRP) from SOLID design principles,
it's preferable to implement the "doubly linked list" and the "LRU Cache" as separate classes, with the linked list used inside LruCache to manage ordering.
In fact, you can import your LinkedList class from the other exercise, and then store each key-value pairs as a tuple.

Alternatively, you can use OrderedDict directly within LruCache to maintain order.

Could you update your code using one of these approaches?

[Emilianouz]

To better adhere to the Single-Responsibility Principle (SRP) from SOLID design principles, it's preferable to implement the "doubly linked list" and the "LRU Cache" as separate classes, with the linked list used inside LruCache to manage ordering. In fact, you can import your LinkedList class from the other exercise, and then store each key-value pairs as a tuple.

Alternatively, you can use OrderedDict directly within LruCache to maintain order.

Could you update your code using one of these approaches?

I've implemented by storing key/value in a Node class. LMKWYT. Thank you.

[cjyuan]

Code is working.

Formatting is not quite consistent. e.g.

• Line 63: no space after ', in parameter list
• Line 62, 75: No space after #

You can install a formatter extension in VSCode and enable "Format on save" to keep all code formatted consistently automatically. (Note: Python formatter extension requires Python runtime to work in VSCode.)

[cjyuan]

You could also just import the linked list class you implemented in the other exercise and then store key-value pair as a tuple.