-
-
Notifications
You must be signed in to change notification settings - Fork 28
Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 2 | Improve code with caches #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
020ef11
9687e70
80bbd88
870d1b9
b5802e9
1429f7d
2cf7251
d85aec6
7477e9d
fa897c1
6f1f754
0e824bb
a771cf7
6ebb9f6
ba0d360
910f67e
2d527ae
08f9869
716d81f
994ee9f
4570e98
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,13 @@ | ||
| cache = {} | ||
|
|
||
| def fibonacci(n): | ||
| if n in cache: | ||
| return cache[n] | ||
|
|
||
| if n <= 1: | ||
| cache[n] = n | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
|
|
||
| result = fibonacci(n - 1) + fibonacci(n - 2) | ||
| cache[n] = result | ||
| return result |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,38 @@ | ||
| from typing import List | ||
|
|
||
| coins = [200, 100, 50, 20, 10, 5, 2, 1] | ||
|
|
||
| cache = {} | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """ | ||
| Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value. | ||
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
| return ways_to_make_change_helper(total, 0) | ||
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coin_index :int) -> int: | ||
| key = (total, coin_index) | ||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| """ | ||
| if total == 0 or len(coins) == 0: | ||
| if key in cache: | ||
| return cache[key] | ||
|
|
||
| if total == 0: | ||
| return 1 | ||
|
|
||
|
|
||
| if coin_index == len(coins): | ||
| return 0 | ||
|
Comment on lines
+15
to
23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: Even though key construction and dictionary lookup are O(1) operations, they are still relatively costly than some simple numerical computation or comparisons (code on lines 18 and 22). This is unrelated to cache, but if you swap the code on lines 18-23 with the code on lines 13-16, you can probably notice some slight improvement in performance. |
||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
| count_of_coin = 1 | ||
| while coin * count_of_coin <= total: | ||
| total_from_coins = coin * count_of_coin | ||
| if total_from_coins == total: | ||
| ways += 1 | ||
| else: | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| ways += intermediate | ||
| count_of_coin += 1 | ||
|
|
||
| coin = coins[coin_index] | ||
| count_of_coin = 0 | ||
| while count_of_coin * coin <= total: | ||
| ways += ways_to_make_change_helper( | ||
| total - count_of_coin * coin, | ||
| coin_index + 1 | ||
| ) | ||
| count_of_coin += 1 | ||
|
|
||
| cache[key] = ways | ||
|
|
||
| return ways | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is to be used as a constant, best practice is to name it with all uppercase letters.
We could also keep the
coinsarray in the parameter. Arrays are pass by reference to a function so the overhead is negligible.