This repository was archived by the owner on Jan 3, 2023. It is now read-only.
West-Midlands_Class-3_HASEEB-KHALIL_JavaScript_2-Week_3#100
Open
Haseeb-Khalil wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
West-Midlands_Class-3_HASEEB-KHALIL_JavaScript_2-Week_3#100Haseeb-Khalil wants to merge 1 commit intoCodeYourFuture:mainfrom
Haseeb-Khalil wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
All projects have been completed apart from "Alarm clock" Unable to make it's stop button to stop the alarm sound. As soon as I get an idea of how to do that. I'll update my code
|
This is really good work, Haseeb! I really love your use of comments so it's really easy to read! If you want a bit of help with that stopAlarm() function, the issue is that the alarmTimeOut variable is locked in the scope of setAlarm. This means that the stopAlarm function can't see it and use it. A way to fix this would either be making a variable in the global scope, so all code blocks can see it, or by moving that stopAlarm function inside of the setAlarm one. |
Sinead-CYF
reviewed
Oct 15, 2021
Sinead-CYF
left a comment
Sinead-CYF
left a comment
There was a problem hiding this comment.
Good job Haseeb 👍
One of my favourite CSS features in the DOM is classList, I also use ems & rems a lot so things are responsive from the outset :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All projects have been completed apart from "Alarm clock"
Unable to make it's stop button to stop the alarm sound.
As soon as I get an idea of how to do that. I'll update my code
Your Details
Homework Details