Glasgow class 6- Siver Omar- JavaScript 2- week 1#265
Glasgow class 6- Siver Omar- JavaScript 2- week 1#265siveromar wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
msimmdev
left a comment
msimmdev
left a comment
There was a problem hiding this comment.
Hi Siver, great work on completing the exercises, I've found very few problems and your work on the writing tests exercises is excellent.
One thing I've noticed throughout your code is in several places the formatting is inconsistent and difficult to read, I'd suggest checking your Visual Studio settings as Prettier should format the code you write for you when you save if enabled correctly. If you can't get this working let's have a look together in class.
|
|
||
| let myCountry = "UnitedKingdom"; | ||
| let myCapitalCity; // complete the code | ||
| let myCapitalCity ="london"; // complete the code |
There was a problem hiding this comment.
Issue: The goal here was to select the capital from the capitalCities object.
For example using capitalCities[myCountry] will access the member of the object based on the value stored in myCountry
| - Use bracket notation to change the value of hasPassed | ||
| */ | ||
|
|
||
| if(student.attendance>=90 && student.examScore>60){student["hasPassed"]=true;} |
There was a problem hiding this comment.
Issue: The formatting of code here is not easily readable
| // write code here | ||
| orderBurger: | ||
| function(balance) | ||
| { if(balance >= MENU.burger){ |
There was a problem hiding this comment.
Issue: The formatting and indentation of code here is not readable
2 participants
Homework Details