This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Jan_Softa_London10_Javascript_Core_2_Week1#226
Open
softacoder wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Jan_Softa_London10_Javascript_Core_2_Week1#226softacoder wants to merge 1 commit intoCodeYourFuture:mainfrom
softacoder wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
saf94
reviewed
Mar 23, 2023
| let cashRegister = { | ||
| // write code here | ||
| } | ||
| orderBurger(balance) { |
There was a problem hiding this comment.
This looks good and works but this is the shorthand approach of adding a method into an object, just to check understanding, do you know how you would define this method without using the shorthand approach? Ie by defining fully the key and the value separately?
saf94
reviewed
Mar 23, 2023
| score: 63 | ||
| } | ||
| */ | ||
| function convertScoreToGrade(score) { |
There was a problem hiding this comment.
Think you might have a bit of stray code copied from above? You can delete this and up till the beginning of line 61 to fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?