-
-
Notifications
You must be signed in to change notification settings - Fork 282
Manchester NW5-Doris Siu-JavaScript1-Week3 #124
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,10 +11,20 @@ | |
| - Hint: you can call the temperatureService function from your function | ||
| */ | ||
|
|
||
| cities1 = ['London', 'Paris','Barcelona','Dubai','Mumbai', 'São Paulo','Lagos']; | ||
|
|
||
| function getTemperatureReport(cities) { | ||
| // TODO | ||
| let arr = []; | ||
| for (let item of cities) { | ||
| let temp = temperatureService(item); | ||
| arr.push (`The temperature in ${item} is ${temp} degrees`); | ||
| } | ||
| return arr; | ||
|
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. really nice solution & use of template literals :) could you think of renaming your |
||
| } | ||
|
|
||
| getTemperatureReport(cities1); | ||
|
|
||
|
|
||
| /* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,20 +5,26 @@ | |
|
|
||
| // This function shouldn't be changed | ||
| function generateRandomNumber() { | ||
| console.log("Generating number..."); | ||
| return Math.round(Math.random() * 100); | ||
| console.log("Generating number..."); | ||
| return Math.round(Math.random() * 100); | ||
| } | ||
|
|
||
| function getRandomNumberGreaterThan50() { | ||
| // TODO - implement using a do-while loop | ||
| // TODO - implement using a do-while loop | ||
| let result = 0; | ||
| do { | ||
| result = generateRandomNumber(); | ||
| } while (result <= 50); | ||
|
|
||
| return result; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. really good use of a do-while loop, well done |
||
| } | ||
|
|
||
| /* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
|
||
| test("Returned value should always be greater than 50", () => { | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,17 @@ | |
| Implement the function below, which will return a new array containing only article titles which will fit. | ||
| */ | ||
| function potentialHeadlines(allArticleTitles) { | ||
| // TODO | ||
| let fitTitleArr = []; | ||
| if (allArticleTitles == null) { | ||
| return fitTitleArr; | ||
| } | ||
| for (let title of allArticleTitles) { | ||
| if (title.length <= 65) { | ||
| fitTitleArr.push(title); | ||
| } | ||
| } | ||
| return fitTitleArr; | ||
| // TODO | ||
| } | ||
|
|
||
| /* | ||
|
|
@@ -14,7 +24,15 @@ function potentialHeadlines(allArticleTitles) { | |
| (you can assume words will always be seperated by a space) | ||
| */ | ||
| function titleWithFewestWords(allArticleTitles) { | ||
| // TODO | ||
| let countArr = []; | ||
| for (let title of allArticleTitles) { | ||
| let titleArr = title.split(" "); | ||
| countArr.push(titleArr); | ||
| } | ||
| let result = countArr.sort((a, b) => a.length - b.length)[0]; | ||
| return result.join(" "); | ||
|
|
||
| // TODO | ||
| } | ||
|
|
||
| /* | ||
|
|
@@ -23,59 +41,79 @@ function titleWithFewestWords(allArticleTitles) { | |
| (Hint: remember that you can also loop through the characters of a string if you need to) | ||
| */ | ||
| function headlinesWithNumbers(allArticleTitles) { | ||
| // TODO | ||
| // TODO | ||
| let numTitleArr = []; | ||
| let conditions = ["1", "2", "3", "4", "5", "6", "7", "8", "9", "0"]; | ||
| for (let title of allArticleTitles) { | ||
| if (conditions.some((el) => title.includes(el))) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this works, but you could use regex so you don't have to type out an array of the conditions :) for example: \d is used to test for numbers present - this is a good site for playing around with regex https://regex101.com/ |
||
| numTitleArr.push(title); | ||
| } | ||
| } | ||
| return numTitleArr; | ||
| } | ||
|
|
||
| /* | ||
| The Financial Times wants to understand what the average number of characters in an article title is. | ||
| Implement the function below to return this number - rounded to the nearest integer. | ||
| */ | ||
| function averageNumberOfCharacters(allArticleTitles) { | ||
| // TODO | ||
| // TODO | ||
| let sum = 0; | ||
| let totalOfArticle = allArticleTitles.length; | ||
| for (let item of allArticleTitles) { | ||
| let strLength = item.length; | ||
| sum += strLength; | ||
| } | ||
| let average = sum / totalOfArticle; | ||
| return Math.round(average); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice solution! |
||
| } | ||
|
|
||
|
|
||
|
|
||
| /* ======= List of Articles - DO NOT MODIFY ===== */ | ||
| const ARTICLE_TITLES = [ | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Amazon Prime Video India country head: streaming is driving a TV revolution", | ||
| "Aerospace chiefs prepare for bumpy ride in recovery of long-haul flights", | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "Chinese social media users blast Elon Musk over near miss in space", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets", | ||
| "The three questions that dominate investment", | ||
| "Brussels urges Chile's incoming president to endorse EU trade deal", | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Amazon Prime Video India country head: streaming is driving a TV revolution", | ||
| "Aerospace chiefs prepare for bumpy ride in recovery of long-haul flights", | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "Chinese social media users blast Elon Musk over near miss in space", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets", | ||
| "The three questions that dominate investment", | ||
| "Brussels urges Chile's incoming president to endorse EU trade deal", | ||
| ]; | ||
|
|
||
| /* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
|
||
| test("should only return potential headlines", () => { | ||
| expect(new Set(potentialHeadlines(ARTICLE_TITLES))).toEqual(new Set([ | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "The three questions that dominate investment" | ||
| ])); | ||
| expect(new Set(potentialHeadlines(ARTICLE_TITLES))).toEqual( | ||
| new Set([ | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "The three questions that dominate investment", | ||
| ]) | ||
| ); | ||
| }); | ||
|
|
||
| test("should return an empty array for empty input", () => { | ||
| expect(potentialHeadlines([])).toEqual([]); | ||
| expect(potentialHeadlines([])).toEqual([]); | ||
| }); | ||
|
|
||
| test("should return the title with the fewest words", () => { | ||
| expect(titleWithFewestWords(ARTICLE_TITLES)).toEqual("The three questions that dominate investment"); | ||
| expect(titleWithFewestWords(ARTICLE_TITLES)).toEqual( | ||
| "The three questions that dominate investment" | ||
| ); | ||
| }); | ||
|
|
||
| test("should only return headlines containing numbers", () => { | ||
| expect(new Set(headlinesWithNumbers(ARTICLE_TITLES))).toEqual(new Set([ | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets" | ||
| ])); | ||
| expect(new Set(headlinesWithNumbers(ARTICLE_TITLES))).toEqual( | ||
| new Set([ | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets", | ||
| ]) | ||
| ); | ||
| }); | ||
|
|
||
| test("should return the average number of characters in a headline", () => { | ||
| expect(averageNumberOfCharacters(ARTICLE_TITLES)).toEqual(65); | ||
| expect(averageNumberOfCharacters(ARTICLE_TITLES)).toEqual(65); | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think You need the loop to add up the first n even numbers,
starting at 0. So if n=3, you need to add up 0+2+4. If n=10 you
need to add up 0+2+4+6+8+10+12+14+16+18.