London Class 9 Lovelace - Tony Arora - HTML/CSS - Week 1,2 and 3 edited together

[Tony-devops]

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

• Your Name: Tony Arora
• Your City: London
• Your Slack Name: Tony devops

Homework Details

• Module: HTML/CSS
• Week: this pull request encompasses week 1,2 and 3. I have closed the pull request London Class 9 - Tony Arora - HTML/CSS - Week 1 #487 as I edited folders on my local machine and had to create a new fork

Notes

• What did you find easy? basic setup of html and css

• What did you find hard? connecting the css for both the pages, color change on input boxes

• What do you still not understand? the checkbox is working but i am still not sure how... based on w3schools i did not use their code to create the tick mark but utilised their background color utility to inject the svg tick image.

• Any other notes?

[VitalinaKuzmenko]

Hi Tony!
My thoughts about your website:

1. It is better to use semantic html. You have tag. It’s great. But you don’t have <footer, <section, <article tags and so on.
2. I like that you made animations when user hover the button. They’re really cool.
3. It is better to center big icons (after text “everyone needs a little Karma.”).
4. Good job with hamburger menu!

Form:

1. Address 2 input shouldn’t be required 😊
2. Terms and conditions box should be required.
3. I don’t know if it’s ok to use so many <br tag. You can try also to use margin to make space where you need on your page😊

To be honest it is really good website. I see that you understand how to use flexbox. Continue working on mobile responsiveness. You are going in the right direction! Let me know if you need any help😊

[VitalinaKuzmenko]

Hi Tony!
My thoughts about your website:

It is better to use semantic html. You have tag. It’s great. But you don’t have <footer, <section, <article tags and so on.
I like that you made animations when user hover the button. They’re really cool.
It is better to center big icons (after text “everyone needs a little Karma.”).
Good job with hamburger menu!
Form:

Address 2 input shouldn’t be required 😊
Terms and conditions box should be required.
I don’t know if it’s ok to use so many <br tag. You can try also to use margin to make space where you need on your page😊
To be honest it is really good website. I see that you understand how to use flexbox. Continue working on mobile responsiveness. You are going in the right direction! Let me know if you need any help😊

[Tony-devops]

thanks Vitalina for the edits

[Mehreenaziz]

Hi Tony!
Your website is very good. You have really nailed the hamburger menu! Also your use of flexbox is great and seamless.

Your code is also easy to understand! Perhaps there could be more semantic tags but it still makes sense how you have laid it out.

Very impressive overall!

[calarasiu]

The page looks very neat. I could only find a few things
s:

• align center the text and images on the section “Everyone needs a little Karma.“

The second address field was not supposed to be requires

• The terms and conditions were supposed to be required field

• You nailed the hamburger menu. the only thing hide the “hamburger-menu” image when the menu is open
  I am impressed with your css knowledge👏