Conversation
bonboh
left a comment
bonboh
left a comment
There was a problem hiding this comment.
Good job @sSalem123! I've left some comments and tips for you to read, but there's nothing else you need to do 👍
| </div> | ||
| </section> | ||
| <section class="panda"> | ||
| <h3>panda storey</h3> |
There was a problem hiding this comment.
| <h3>panda storey</h3> | |
| <h2>panda storey</h2> |
The other animal sections use h2 so we should use that as well so it has the same heading level
| img { | ||
| border: 5px solid #8075ff; | ||
| } | ||
| */ |
There was a problem hiding this comment.
Software teams usually don't leave commented code. We can delete the commented code here
| } | ||
|
|
||
| .giraffe p:first-child { | ||
| font-size: 20px; |
There was a problem hiding this comment.
| font-size: 20px; | |
| font-size: 1.25rem; |
We should use relative units where possible, so that if a user changes their browser default font size setting then everything changes size proportionally
|
|
||
| /*Education*/ | ||
|
|
||
| button:hover { |
There was a problem hiding this comment.
| button:hover { | |
| button:focus, | |
| button:hover { |
We should also add :focus so that when a user uses the Tab key to move to a button, it also changes to green
|
|
||
| button:hover, | ||
| button:focus { | ||
| background-color: #F4743B; |
There was a problem hiding this comment.
We already have button:hover above on line 177 so we can move background-color: #F4743B; there
|
|
||
| .membership p:first-child { | ||
| width: 700px; | ||
| margin: 1rem 1rem 0.5rem 1.5rem; |
There was a problem hiding this comment.
| margin: 1rem 1rem 0.5rem 1.5rem; | |
| margin: auto; |
Alternatively, we can use auto which centres the element. auto distributes the margin around it equally
|
|
||
| .programs { | ||
| width: 97%; | ||
| height: auto; |
There was a problem hiding this comment.
| height: auto; |
We don't need height: auto because auto is the default value of height so it already applies
| .programs { | ||
| width: 97%; | ||
| height: auto; | ||
| padding: 10px; |
There was a problem hiding this comment.
| padding: 10px; | |
| padding: 0.75rem; |
We should use relative units where possible, so rem instead of px
2 participants
No description provided.