Tags: CipherOne/CacheLib
Tags
Fix deprecated behaviour in cachelib/common/PercentileStats.cpp
Summary:
Future C++ standards and compiler upgrades will eliminate deprecated behaviour. `-Wdeprecated` identifies this behaviour and has found some in this code!
Some examples.
**Dynamic exceptions**
```
error: dynamic exception specifications are deprecated [-Werror,-Wdeprecated-dynamic-exception-spec]
```
`throw(...)` has been deprecated since C++11 and removed in C++17. In most cases we can just use `noexcept` in the rest, we can remove this.
**Implicit copy constructors**
```
error: definition of implicit copy constructor for 'XXX' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated-copy-with-dtor]
```
If you define a destructor, you need to explicitly define a copy constructor.
**Out-ofline constexpr static**
```
error: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated]
```
This can be simplified:
```
class MyClass {
static constexpr my_const = 3;
};
static constexpr MyClass::my_const; // <- No longer needed!
```
Reviewed By: meyering
Differential Revision: D54158205
fbshipit-source-id: c6909e9542bdd36a096768013e791b4763975b6e
Updating submodules Summary: GitHub commits: facebook@362ab87 facebook/fb303@1fad48d facebook/fbthrift@5991220 facebook/folly@323e467 facebook/litho@de67ef6 facebook/mcrouter@664737d facebook/mvfst@5d6bd54 facebook/proxygen@ed938d2 facebook/rocksdb@28c1c15 facebook/squangle@d24dedf facebook/wangle@3fbb538 facebook/watchman@4307373 facebookexperimental/edencommon@b25e8f6 facebookexperimental/rust-shed@f3e4fc2 facebookincubator/katran@b3f1e01 facebookincubator/velox@dadade0 facebookresearch/multimodal@1cccc58 facebookresearch/vrs@b8e8e64 pytorch/kineto@dcb3aab Reviewed By: bigfootjon fbshipit-source-id: ab8b2023c57a151279117f6c4225affa454a2aae
Updating submodules Summary: GitHub commits: facebook@6e6c0f2 facebook/fb303@0b1e4c1 facebook/fbthrift@0f1fb2d facebook/mvfst@0750a89 facebook/proxygen@3bf86e4 facebook/wangle@5637b21 facebook/watchman@a88b526 facebookexperimental/edencommon@27d8f5e facebookexperimental/rust-shed@82d763d facebookincubator/fizz@71222fc facebookincubator/katran@d53e54a facebookincubator/velox@7b68a82 Reviewed By: jurajh-fb fbshipit-source-id: 75ebf727c3949fc7efbde73d50f214386f8bfc79
Updating submodules Summary: GitHub commits: facebook@e040b5d facebook/fb303@3091c95 facebook/fbthrift@03c2fd0 facebook/folly@718e602 facebook/mvfst@6362aaf facebook/proxygen@9cd5d3f facebook/wangle@2d07ba7 facebook/watchman@9251157 facebookexperimental/edencommon@17b269f facebookexperimental/rust-shed@2335e04 facebookincubator/fizz@4c58504 facebookincubator/katran@631dc40 facebookincubator/superconsole@5f1b407 facebookincubator/velox@735b8f4 pytorch/FBGEMM@dad9720 Reviewed By: jailby fbshipit-source-id: be997aa3d80d7feff156d30e2168581eeae1be6d
Updating submodules Summary: GitHub commits: facebook@246a4d1 facebook/fb303@e688c01 facebook/fbthrift@564bf50 facebook/mvfst@5bf2abb facebook/proxygen@6b34904 facebook/wangle@9d0dc39 facebook/watchman@a76f994 facebookexperimental/edencommon@f3a58d7 facebookexperimental/rust-shed@0b57fe5 facebookincubator/fizz@020b2a1 facebookincubator/katran@75a0dae facebookresearch/vrs@ee02184 Reviewed By: bigfootjon fbshipit-source-id: d6ca902a49b30d0fcf88322c586720f441437d6d
Updating submodules Summary: GitHub commits: facebook@a20b368 facebook/fb303@3ceb910 facebook/fbthrift@275badd facebook/folly@311ca18 facebook/mvfst@edfffc5 facebook/proxygen@baa18b4 facebook/rocksdb@800cfae facebook/wangle@05ab4ed facebook/watchman@8c78929 facebookexperimental/edencommon@5aef9ab facebookexperimental/rust-shed@33d150e facebookincubator/fizz@9fb4a7b facebookincubator/katran@9643811 Reviewed By: jurajh-fb fbshipit-source-id: 2e13006de8c896fffba54d1ef1672c633d6f9805
Updating submodules Summary: GitHub commits: facebook@08fac97 facebook/fb303@e4e0594 facebook/fbthrift@01297c8 facebook/folly@7e9cbfe facebook/mvfst@907162f facebook/ocamlrep@81fde0c facebook/proxygen@fd652f5 facebook/wangle@b768b85 facebook/watchman@448a51c facebookexperimental/edencommon@70d100a facebookexperimental/rust-shed@4a0f1ac facebookincubator/fizz@b8ca1c0 facebookincubator/katran@bdf42ef Reviewed By: jailby fbshipit-source-id: 04b03519fb9d8c7a6cfb27a4524b0466831c300b
Updating submodules Summary: GitHub commits: facebook@c536791 facebook/fb303@383f36a facebook/fbthrift@f668115 facebook/mvfst@442f483 facebook/ocamlrep@3d5015b facebook/proxygen@25a521a facebook/wangle@0f6bdb2 facebook/watchman@0bc8b83 facebookexperimental/edencommon@1a990af facebookexperimental/rust-shed@dd542a1 facebookincubator/fizz@f1ff660 facebookincubator/katran@65d9108 Reviewed By: jurajh-fb fbshipit-source-id: eb90031f0a8e3d4aa362585a358443d7bb2ca027
Updating submodules Summary: GitHub commits: facebook@474e3eb facebook/fb303@7868603 facebook/fbthrift@d63c976 facebook/mvfst@0cc53c9 facebook/proxygen@bfd7877 facebook/wangle@019cd37 facebook/watchman@61c1603 facebookexperimental/edencommon@3247920 facebookexperimental/rust-shed@496611d facebookincubator/fizz@8007aff facebookincubator/katran@d04374c facebookincubator/velox@523e561 Reviewed By: bigfootjon fbshipit-source-id: 80c46c2b81819e5291f2933fbac115591a359fb5
PreviousNext