Skip to content

Conversation

@herbsee02
Copy link

@herbsee02 herbsee02 commented Oct 1, 2025

Implemented a CLT for the motion brick "Spin Left/Right _ Degrees/Second". The test works on two Layers:

  • The Look-Direction of an object in a scene is checked at specific timestamps. A tolerance is used for the angle to ensure that the test doesn't become flaky.
  • The Pixel-Colors are compared to defined values at specific timestamps to verify that the rendering is working.

Furthermore, the test covers clockwise and counterclockwise rotations, edge values, and combined rotations in succession.

https://catrobat.atlassian.net/browse/IDE-293

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@reichli reichli added the Active Member Tickets that are assigned to members that are still currently active label Dec 25, 2025
@dorianpercic dorianpercic self-requested a review December 26, 2025 12:52
@dorianpercic
Copy link
Contributor

Rebased PR.

@dorianpercic
Copy link
Contributor

dorianpercic commented Dec 29, 2025

This test gets never executed, neither locally nor in the Jenkins pipeline. Reason is, if some test throws a NullPointerException the whole suite is aborted. Most commonly the testChangeSize.catrobat CLT throws a NullPointerException, that's why the suite does not execute all tests. Currently investigating on how to fix this.

@dorianpercic
Copy link
Contributor

Fixed the CatrobatTestRunner and fixed one CLT test.

@sonarqubecloud
Copy link

Copy link
Contributor

@dorianpercic dorianpercic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants