Skip to content

[squid:S1143] "return" statements should not occur in "finally" blocks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AymanDF wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[squid:S1143] "return" statements should not occur in "finally" blocks #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions davinci/src/main/java/cn/hadcn/davinci/volley/toolbox/DiskBasedCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,27 +110,28 @@ public synchronized Entry get(String key) {
if (entry == null) {
return null;
}

Entry resultEntry = null;
File file = getFileForKey(key);
CountingInputStream cis = null;
try {
cis = new CountingInputStream(new BufferedInputStream(new FileInputStream(file)));
CacheHeader.readHeader(cis); // eat header
byte[] data = streamToBytes(cis, (int) (file.length() - cis.bytesRead));
return entry.toCacheEntry(data);
resultEntry = entry.toCacheEntry(data);
} catch (IOException e) {
VolleyLog.d("%s: %s", file.getAbsolutePath(), e.toString());
remove(key);
return null;
resultEntry = null;
} finally {
if (cis != null) {
try {
cis.close();
} catch (IOException ioe) {
return null;
resultEntry = null;
}
}
}
return resultEntry;
}

/**
Expand Down