Skip to content

Conversation

@MobileVet
Copy link

This resolves the crash on iOS 6 and has no impact on iOS 7+.

Ideally, we think it might be best to rethink the view hierarchy and NOT move the contentView out of the UITableViewCell root, but instead pull the subviews out and place those in the ScrollView. That would require substantial reworking though so we opted for this in the near term.

Hopefully this will help some other folks in the mean time.
Great library!
MV

@zygoat
Copy link
Contributor

zygoat commented May 22, 2014

The problem with extracting the subviews is that it defeats run-time view setup in the subclass; that is to say, it makes it impossible to substitute SWTableViewCell for UITableViewCell in an existing implementation without re-writing the subclass to know about SWTVC's specific view hierarchy requirement.

SWTVC used to work that way before I implemented all the auto-layout stuff. Part of my goal was to address this problem so as to make SWTVC more properly a drop-in replacement for UITableViewCell.

(Of course, the error I made was in not testing properly on iOS 6, and then not anticipating the grossness of the workarounds required to cope with the layout bugs therein. Sigh…)

@zygoat zygoat mentioned this pull request May 22, 2014
@MobileVet
Copy link
Author

Good point about the extraction defeating the drop in nature...

Well, this change does resolve the crash.

@Pacha56
Copy link

Pacha56 commented Jun 16, 2014

With the fix my App stopped crashing in iOS >= 6.0 but swipeableTableViewCellShouldHideUtilityButtonsOnSwipe doesn't work now.

Any suggestions?

@bawn
Copy link

bawn commented Aug 25, 2014

This problem has been bothering me for a long time

anivaros pushed a commit to anivaros/SWTableViewCell that referenced this pull request Jun 22, 2018
anivaros pushed a commit to anivaros/SWTableViewCell that referenced this pull request Jun 22, 2018
… problems with reused buttons among many cells
@MobileVet MobileVet closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants