Skip to content

Conversation

@Alessandro-Barbieri
Copy link
Contributor

@Alessandro-Barbieri Alessandro-Barbieri marked this pull request as ready for review December 16, 2025 01:49
@BreakBB
Copy link
Owner

BreakBB commented Dec 18, 2025

I don't think it is correct to rename "Spell Damage" to "Spell Power". Spell Power was introduced in WotLK to combine Spell Damage and Healing Power. While it would be correct for WotLK I don't think it is worth curating multiple translations for this difference.

That being that, I'd be happy to see #375 fixed if it is indeed incorrect to add that 1% to the spell damage value.

@BreakBB BreakBB added the bug Something isn't working label Dec 18, 2025
@Alessandro-Barbieri
Copy link
Contributor Author

What's the best wording that doesn't confuse the user? Something that doesn't sound that the value shown is the final damage (comprehensive of bonuses) but only the "power".

@Alessandro-Barbieri Alessandro-Barbieri changed the title rename spell damage to spell power Remove Arcane Power talent from spell damage calculation Dec 18, 2025
@BreakBB
Copy link
Owner

BreakBB commented Dec 22, 2025

What's the best wording that doesn't confuse the user? Something that doesn't sound that the value shown is the final damage (comprehensive of bonuses) but only the "power".

I have no clue tbh. I do get your point though, that it might not be clear that the value shown is not the actual spell damage, but only a part of the damage bonus 🤔 Could a "bonus" help here?

@BreakBB
Copy link
Owner

BreakBB commented Dec 23, 2025

I am honestly not sure how to proceed with this PR. Changing the wording from "nature damage" to "nature spell damage" (and so on) means, that all the translations for this also become invalid. And I am not sure if anything becomes more clear when adding "spell". What would it be confused with in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants