fix(tui): support editor commands with arguments #2
+29
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use shell.Fields from mvdan.cc/sh/v3 to parse editor config, allowing commands like 'zed --wait' or 'ghostty -e fish -c "crush"'. Previously the entire editor string was passed to exec.LookPath and exec.Command, treating 'zed --wait' as a single binary name. Assisted-by: Claude Opus 4.5 via Crush
Owner
|
thanks for contributing. will review it and merge it. |
Owner
|
Merged — thanks again for the contribution! 🙌 |
Owner
|
I’m tagging v1.2.2 shortly and will credit you in the release notes and CONTRIBUTING.md. |
Contributor
Author
|
@Bharath-code I've wanted something like this for a while and you've done all the hard work of making it, so thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
shell.Fieldsfrommvdan.cc/sh/v3to parse editor config, allowing commands likezed --waitorghostty -e fish -c "crush".Previously the entire editor string was passed to
exec.LookPathandexec.Command, treatingzed --waitas a single binary name.Assisted-by: Claude Opus 4.5 via Crush