Fixed the issues with the timepicker (jQuery) not working properly #1193
Open
tylercraig9332 wants to merge 2 commits intoAppStateESS:leftNavfrom
Open
Fixed the issues with the timepicker (jQuery) not working properly #1193tylercraig9332 wants to merge 2 commits intoAppStateESS:leftNavfrom
tylercraig9332 wants to merge 2 commits intoAppStateESS:leftNavfrom
Conversation
Contributor
|
Yes, we definitely want to update to a Bootstrap modal dialog instead of the jQuery UI dialog. It's probably time to move to a more updated timepicker then, if this one hasn't kept up with changes in jQuery. I tried to find a project for the one we're using, to see if they have an updated version, but it doesn't appear to be maintained anymore. Perhaps try this project instead: http://timepicker.co/ We should include that project via their npm package, instead of including the code directly in our project (and therefore remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, JQuery removed the $.browser method in 1.9 which I added onto to the timepicker file that used it. I'm not sure if that's the best idea; I feel that it would have been better to make a js file/class that would return the browser, so if other files use it we can reuse the code.
Also, I think we talked about using a Bootstrap modal instead of a JQuery one. I can work on this if needed.