Open
Conversation
kelichiu
reviewed
Jan 26, 2025
|
|
||
| SELECT * | ||
| FROM customer_purchases | ||
| WHERE product_id = '4' or product_id = '9'; |
There was a problem hiding this comment.
Data of product_id is integer, you don't actually need to wrap them with ''.
kelichiu
reviewed
Jan 26, 2025
| quantity * cost_to_customer_per_qty AS price | ||
| FROM customer_purchases | ||
| WHERE vendor_id BETWEEN 8 AND 10; | ||
| -- option 2 |
There was a problem hiding this comment.
We will need to provide another solution using BETWEEN.
kelichiu
suggested changes
Jan 26, 2025
kelichiu
left a comment
kelichiu
left a comment
There was a problem hiding this comment.
Point: 28/30
Section 1: ✅ Complete
Section 2: ☑️ Partial
WHERE Question 2
In the original file, it's asking you to solve this question using
1. two conditions using AND
2. one condition using BETWEEN
Todo:
You have successfully done 1, please complete 2.
Section 3: ☑️ Partial
Aggregate Question 2
Minor error
Todo:
- Remove the extra
-within theONclause
Section 4: ✅ Complete
Thank you Anna for the thoughtful reflection, I enjoyed reading it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added code to complete assignment one.
What did you learn from the changes you have made?
I learned logical models, basic commands (select, from, where), case, join, aggregation, temp tables, datetime functions
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
none
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
none
How were these changes tested?
I tested the code on DB Browser for SQLite.
A reference to a related issue in your repository (if applicable)
Checklist