Assignment-two

[AlexanderTheAlright]

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I was trying to make a logical model for a potential bookstore, perform some queries for my favourite manager, cross joining some tables, reflect on the all too human limitations of neural nets.

What did you learn from the changes you have made?

I learned how to conceptualize logical data relations more explicitly and (try to) respect cardinality. Much more to learn here!

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Yes I tried out many different logical models. One where sales was aggregated, one where it was separate, one where models were more explicit. Not much experimentation with the code but definitely with the logical modelling.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Yes I was mixing up my keys. I tried to overcome it by first reducing my model to PK and FK before adding any more relationships. Building out more emergently.

How were these changes tested?

Mainly by my review. Needed more formal testing.

A reference to a related issue in your repository (if applicable)

NA

Checklist

• [x ] I can confirm that my changes are working as intended

[anjali-deshpande-hub]

Well done 70/70

I have just one observation. The PR for assignment 2 has 19 File changes. It should have 4-5 File changes only. In the real work environment, you want to make sure that the PR has only files that are related to the new feature/fix being made. Reviewers check to see if you have the correct files in the PR. Missing or unnecessary files, or incorrect folder structures can cause build issues or deployment issues.

For future assignments try to include only files that are part of the Pull request.