Open
Conversation
anjali-deshpande-hub
approved these changes
Nov 7, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Very well done! 30/30
Thank you for your thoughtful feedback on Section 4. I think your professor's take on saying 'hi' to a dataset resonates with me, especially when you say that behind every row is a human being represented by it, and with every human comes their complexity. We have to strive to build systems that honor that complexity.
Another observation. I noticed that the number of file changes with this PR were 15. I was expecting only 3 file changes under DC_Cohort dir. In future, you can make sure that only relevant changes are part of the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I did three main things in this pull request:
What did you learn from the changes you have made?
I learned to quickly develop logical models, perform basic sql operations, and to reflect more explicitly on the values guiding the construction of datasets.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I thought about many different logical models. Vender to product, customer to purchase, but decided upon the postal code data because I thought it was the most interesting.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No major challenges. I initially struggled on exactly the right format for the partial data models lines (e.g., whether to write it plain, 1 to many, or to use crow's annotation).
How were these changes tested?
I checked the examples and materials from the lectures to confirm I was following the same logic.
A reference to a related issue in your repository (if applicable)
NA
Checklist