Conversation
anjali-deshpande-hub
approved these changes
Oct 10, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Well done! I loved your PR comments. It can be used to showcase how PR should be commented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make?
I completed and refined the
assignment.shscript to automate project setup and data organization. The script now:analysis,output,data, and subfolders for processed logs).What did you learn from the changes you have made?
I learned how to use core Bash commands (
mkdir,mv,cp,rm, andfind) to automate directory creation and file management. I also practiced ensuring portability by using relative paths and verifying that scripts run correctly in any environment.Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered using loops or conditionals to handle each log type more dynamically but decided to keep the logic simple and explicit since the instructions specified fixed categories.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The main challenge was ensuring the correct handling of wildcard patterns when copying log files into subfolders. Initially, some patterns overlapped or missed matches. I resolved this by testing each pattern independently and verifying output using
ls.Another challenge was managing Git commits and branches correctly in Bash; I practiced using branch isolation and learned to avoid committing generated directories.
How were these changes tested?
I ran the script multiple times locally using
bash assignment.sh, confirming that:inventory.txtfile listed all processed files accurately.I also cleaned up (
rm -rf newproject/) between runs to ensure consistent results.A reference to a related issue in your repository (if applicable)
N/A
Checklist