added php7.2 and php 7.3 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 27, 2018 11:05
ADD added /root/.composer/vendor/bin to PATH MOD PEAR: phing package depcrecated install via composer MOD sed command failed. MOD nginx-site.conf moved to /etc/nginx/conf.d/ instead of /etc/nginx/sites-enabled/default DEL removed mcrypt for php7.2 and php7.3 deprecated
adepretis
reviewed
Jan 3, 2019
| COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf | ||
| COPY nginx-site.conf /etc/nginx/sites-enabled/default | ||
| COPY nginx-site.conf /etc/nginx/conf.d/default.conf |
Member
There was a problem hiding this comment.
please leave /etc/nginx/sites-enabled/default - images using this base image rely on sites-enabled/default and remove conf.d/default.conf ... having sites-enabled/ is also the Ubuntu default for nginx.
Author
There was a problem hiding this comment.
i've looked into it: the nginx version which is used here, does not have a sites-enabled directory.
based on this post What is the different usages for sites-available vs the conf.d directory for nginx, i think the current approch is good.
if you insist in having a sites-enabled directory, we have to sed the nginx.conf which will probably fail in future (if it gets modified)
added 7 commits
January 4, 2019 10:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADD added
/root/.composer/vendor/binto PATHMOD PEAR:
phingpackage deprecated install via composerMOD
sedcommand failed.MOD
nginx-site.confmoved to/etc/nginx/conf.d/instead of/etc/nginx/sites-enabled/defaultDEL removed
mcryptfor php7.2 and php7.3 deprecated