Skip to content

Conversation

@sasuke0787
Copy link
Contributor

🚀 Legacy Address Support & Version Number Fix

Changes

This PR addresses two issues:

1. Legacy Address Support

Problem:
Legacy accounts (using v5/16-byte address format) were failing to send transactions. These accounts experienced errors like "INSUFFICIENT_BALANCE_FOR_TRANSACTION_FEE" or "BAD_CHAIN_ID" even when they had sufficient balance.

Solution:

  • Created a common create_sender_with_legacy function to centralize legacy address handling
  • Modified transaction functions to properly initialize the Sender with the legacy flag
  • Ensured all transaction types (transfers, vouches, etc.) properly support legacy accounts
  • Added legacy detection in the frontend components based on address format
  • Applied the same pattern used in CLI's --legacy-address flag for consistency

Affected files:

  • src-tauri/src/commands/tx.rs - Core transaction functions and legacy support
  • Frontend components updated to pass legacy flag:
    • src/components/txs/Transactions.svelte
    • src/components/txs/VouchForm.svelte
    • src/components/txs/RevokeForm.svelte
    • src/components/wallet/MigrationStatus.svelte
    • src/components/txs/CwReauthForm.svelte

2. Version Number Fix

Problem:
The application was displaying an incorrect version number (1.0.5) instead of the latest version.

Solution:

  • Updated version number in src-tauri/Cargo.toml and other required files
  • Ensured version is properly propagated to the UI

Testing

Legacy Address Support:

  • Tested coin transfers with legacy accounts ✅
  • Tested vouching with legacy accounts ✅
  • Tested community wallet operations with legacy accounts ✅
  • Verified chain ID handling is correct ✅

Version Number:

  • Verified correct version displays in the app interface ✅

Related Issues

Closes #322
Closes #340

@sasuke0787 sasuke0787 requested a review from 0o-de-lally June 23, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Version number in about shows 1.0.5 [Bug] legacy address option is not being used for address which have conflicting auth keys

1 participant