Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lfthwjx/effective-javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: zs410612607/effective-javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 11 files changed
  • 5 contributors

Commits on Nov 15, 2016

  1. fix typo

    @Riokai
    Riokai authored Nov 15, 2016
    Configuration menu
    Copy the full SHA
    2bbd242 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @Riokai
    Riokai authored Nov 15, 2016
    Configuration menu
    Copy the full SHA
    64783ae View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from Riokai/master 

    fix typo
    @dreamapplehappy
    dreamapplehappy authored Nov 15, 2016
    Configuration menu
    Copy the full SHA
    f41a002 View commit details
    Browse the repository at this point in the history

  4. 修改item13中的一个错误

    @dreamapplehappy
    dreamapplehappy committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    4d8f1b9 View commit details
    Browse the repository at this point in the history

  5. fix item13 

    fix item13
    @dreamapplehappy
    dreamapplehappy committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    e69b532 View commit details
    Browse the repository at this point in the history

  6. fix item13

    @dreamapplehappy
    dreamapplehappy committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    420835c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2016

  1. add some explanation 

    0
    @dreamapplehappy
    dreamapplehappy committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    3bde49a View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2016

  1. 修复 chapter1 item4的一个问题

    @dreamapplehappy
    dreamapplehappy committed Nov 23, 2016
    Configuration menu
    Copy the full SHA
    a6b0ee5 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2017

  1. fix special variable name 'top' bug 

    Uncaught TypeError: top.addChild is not a function,参考链接http://blog.csdn.net/u010689306/article/details/53130367
    sheldon shen authored Feb 19, 2017
    Configuration menu
    Copy the full SHA
    a21859c View commit details
    Browse the repository at this point in the history

  2. fix special variable name 'top' bug 

    Uncaught TypeError: top.addChild is not a function,参考链接http://blog.csdn.net/u010689306/article/details/53130367
    sheldon shen authored Feb 19, 2017
    Configuration menu
    Copy the full SHA
    3f312df View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2017

  1. Merge pull request #5 from JavaScriptSexy/master 

    fix special variable name 'top' bug
    @dreamapplehappy
    dreamapplehappy authored Feb 20, 2017
    Configuration menu
    Copy the full SHA
    8d26aa3 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. update top things 

    top 对象是没有 children 属性的 应该是  left right middle 之一
    @aristotll
    aristotll authored Jan 24, 2018
    Configuration menu
    Copy the full SHA
    8e7f2f8 View commit details
    Browse the repository at this point in the history

  2. Update demo.js 

    same as previous commit;
    @aristotll
    aristotll authored Jan 24, 2018
    Configuration menu
    Copy the full SHA
    e023f3b View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Merge pull request #8 from aristotll/patch-1 

    修改 top 相关内容
    @dreamapplehappy
    dreamapplehappy authored Feb 1, 2018
    Configuration menu
    Copy the full SHA
    5718110 View commit details
    Browse the repository at this point in the history

  2. update

    @dreamapplehappy
    dreamapplehappy committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    366944f View commit details
    Browse the repository at this point in the history

  3. fix issue 7

    @dreamapplehappy
    dreamapplehappy committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    e5c3735 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2018

  1. fix link of item 68

    @xiedacon
    xiedacon authored Feb 10, 2018
    Configuration menu
    Copy the full SHA
    129fe24 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Merge pull request #9 from xiedacon/patch-1 

    fix link of item 68
    @dreamapplehappy
    dreamapplehappy authored Feb 12, 2018
    Configuration menu
    Copy the full SHA
    a0d947d View commit details
    Browse the repository at this point in the history
Loading