Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bitwalker/timex
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: welect/timex
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Apr 26, 2023

  1. Fix: preserve datetime precision after Timex.shift/2

    Resolves #731
    
    Unfortunately this broke with elixir-lang/elixir@5a583c7
    which was release with Elixir 1.14.3
    
    Elixir 1.13.4:
    
    ```
    iex(3)> DateTime.utc_now() |> IO.inspect() |> DateTime.truncate(:second) |> IO.inspect() |> Timex.shift(minutes: 1) |> IO.inspect()
    ~U[2023-04-13 09:56:10.136274Z]
    ~U[2023-04-13 09:56:10Z]
    ~U[2023-04-13 09:57:10Z]
    ```
    
    Elixir 1.14.4:
    
    ```
    iex(1)> DateTime.utc_now() |> IO.inspect() |> DateTime.truncate(:second) |> IO.inspect() |> Timex.shift(minutes: 1) |> IO.inspect()
    ~U[2023-04-13 09:55:16.405357Z]
    ~U[2023-04-13 09:55:16Z]
    ~U[2023-04-13 09:56:16.000000Z]
    ```
    tfiedlerdejanze committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4c00c0b View commit details
    Browse the repository at this point in the history
Loading