Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: buffmail/react-contextmenu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: vkbansal/react-contextmenu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 7 files changed
  • 13 contributors

Commits on Nov 14, 2019

  1. Prop type of renderTag changed to elementType. Fixes vkbansal#300 (vk… 

    …bansal#301)
    @glebpl @vkbansal
    glebpl authored and vkbansal committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    378c113 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Updated README.md with a warning (vkbansal#303) 

    * Updated README.md with a warning

I spent a lot of time debugging the `onClick` for `MenuItem` and after trying again and again I found in the issue tracker a comment explaining that every single instance of `ContextMenu` and `ContextMenuTrigger` needs to have a unique `id` they cannot share one even if they are the same component or use the same menu. 

I think this a good change to make to the docs since it's very small and can help people prevent people from wasting time debugging. Thank you for your time.

* Update README.md
    @taimoorgit @vkbansal
    taimoorgit authored and vkbansal committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    1390a2f View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Now exporting prop interfaces for extending (vkbansal#306) 

    * Now exporting prop interfaces for extending

* Moved to module

* Flattened exports
    @R4VANG3R @vkbansal
    R4VANG3R authored and vkbansal committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    d4b77aa View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. types: missing props from PropTypes (vkbansal#310)

    @hmelenok @vkbansal
    hmelenok authored and vkbansal committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    99e2268 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Updated usage to include currently active menu item class. (vkbansal#314 

    )

`react-contextmenu-item--selected` : Is applied to currently selected menu item. This information may help people. As people often style the currently selected/active menu item.
    @theBstar
    theBstar authored Feb 10, 2020
    Configuration menu
    Copy the full SHA
    ab5b8f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Improve connectMenu type (vkbansal#318) 

    * Improve connectMenu type

Changed connectMenu type to specify that the function deals with React components, not just any

* Export ConnectMenuProps
    @FraserWaters-GR
    FraserWaters-GR authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    13e3271 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Update README.md NOTICE warning (vkbansal#322)

    @DylanYang0523
    DylanYang0523 authored Apr 1, 2020
    Configuration menu
    Copy the full SHA
    84f19bb View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. v2.14.0

    @vkbansal
    vkbansal committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    c683250 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Bugfix- Close submenu on left arrow key press (vkbansal#333) 

    * Bugfix- Close submenu on left arrow key press

* left arrow key handled for submenu

Co-authored-by: sankajai <Administrator@no1010042065126.corp.adobe.com>
    @sanu3191
    sanu3191 and sankajai authored Jun 29, 2020
    Configuration menu
    Copy the full SHA
    71625ec View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Update ContextMenuTriggerProps to allow custom props (vkbansal#334)

    @pzi
    pzi authored Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a82e0d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Bump lodash from 4.17.15 to 4.17.19 (vkbansal#336) 

    Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e451748 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2020

  1. Bump elliptic from 6.5.1 to 6.5.3 (vkbansal#338) 

    Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.1 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.1...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Aug 2, 2020
    Configuration menu
    Copy the full SHA
    f3ccbdb View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Update README.md

    @vkbansal
    vkbansal authored Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d9018db View commit details
    Browse the repository at this point in the history
Loading