Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: matplotlib/matplotlib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: vitalybuka/matplotlib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 31, 2020

  1. Fix "out of bounds" undefined behavior 

    This is detected with clang and -fsanitizer=bounds.

Out-of-bound addressing array of fixed size is undefined
behavior in both C and C++. It is so even if underlying
memory is properly allocated. To avoid undefined behavior
in cases like this C99 added feature called "flexible array member"
when size of array is omitted.

Unfortunately it's not C++ feature. However both clang++ and
g++ this and this seems the only reasonable way
to avoid undefined behavior without significant rewriting such code.
    @vitalybuka
    vitalybuka committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    4974a24 View commit details
    Browse the repository at this point in the history
Loading