From 0c46d01fd77f99072b706010f92b7ffb4929c02b Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 2 Oct 2022 15:29:43 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- .../models/rnn/translate/data_utils.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/jni/tensorflow/models/rnn/translate/data_utils.py b/jni/tensorflow/models/rnn/translate/data_utils.py index 250762a..5eac7c5 100644 --- a/jni/tensorflow/models/rnn/translate/data_utils.py +++ b/jni/tensorflow/models/rnn/translate/data_utils.py @@ -78,7 +78,26 @@ def get_wmt_enfr_train_set(directory): _WMT_ENFR_TRAIN_URL) print("Extracting tar file %s" % corpus_file) with tarfile.open(corpus_file, "r") as corpus_tar: - corpus_tar.extractall(directory) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(corpus_tar, directory) gunzip_file(train_path + ".fr.gz", train_path + ".fr") gunzip_file(train_path + ".en.gz", train_path + ".en") return train_path From 97dd71d376496f18d4124645aaf66421e2c36e3e Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 18:42:38 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- jni/tensorflow/models/rnn/translate/data_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jni/tensorflow/models/rnn/translate/data_utils.py b/jni/tensorflow/models/rnn/translate/data_utils.py index 5eac7c5..597adcf 100644 --- a/jni/tensorflow/models/rnn/translate/data_utils.py +++ b/jni/tensorflow/models/rnn/translate/data_utils.py @@ -94,7 +94,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(corpus_tar, directory)